Fix heli ice/turbine cooldown and add autotest #28310
Merged
+62
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKear
force-pushed
the
pr_heli_add_turbine_cooldown_test
branch
from
dea3f25
to
d197221
Compare
|
Auto test results before the fix: Auto test results after the fix: |
peterbarker
approved these changes
Oct 6, 2024
Comment on lines
+708
to
+712
| self.set_parameter("RC6_OPTION", 161) | ||
| self.set_parameter("H_RSC_RAMP_TIME", RAMP_TIME) | ||
| self.set_parameter("H_RSC_SETPOINT", SETPOINT) | ||
| self.set_parameter("H_RSC_IDLE", IDLE) | ||
| self.set_parameter("H_RSC_CLDWN_TIME", COOLDOWN_TIME) |
There was a problem hiding this comment.
set_parameters can be faster.
Comment on lines
+720
to
+721
| self.set_rc(6, 2000) | ||
| self.wait_statustext('Turbine startup') |
There was a problem hiding this comment.
There's a race condition here, should collect statustext in the context and check_context=True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ice/turbine cool down feature in Heli RSC.
This also adds an autotest to prevent future regression.