Skip to content

Commit

Permalink
Correct test error
Browse files Browse the repository at this point in the history
  • Loading branch information
reverendbedford committed Jan 11, 2023
1 parent 803c8d9 commit 5f08d7f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
btype: [Release, Debug]
btype: [Release]
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -14,7 +14,7 @@ jobs:
- run: sudo apt install build-essential cmake libblas-dev liblapack-dev python3-dev python3-networkx python3-numpy python3-scipy python3-matplotlib python3-nose2
- run: cmake -D CMAKE_BUILD_TYPE=${{ matrix.btype }} -D WRAP_PYTHON=ON .
- run: make -j 2
- run: nose2-3 --output-buffer
- run: nose2-3
test-base-linux:
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -44,7 +44,8 @@ jobs:
- run: pip3 install --user networkx numpy scipy matplotlib nose2
- run: cmake -D CMAKE_BUILD_TYPE=${{ matrix.btype }} -D WRAP_PYTHON=ON -D PYTHON_EXECUTABLE=$(python3-config --prefix)/bin/python3.11 -D PYTHON_LIBRARY=$(python3-config --prefix)/lib/libpython3.11.dylib -D PYTHON_INCLUDE_DIR=$(python3-config --prefix)/include/python3.11 -D USE_OPENMP=OFF .
- run: make -j 2
- run: ~/Library/Python/3.11/bin/nose2 --output-buffer
- run: which nose2
- run: nose2 --output-buffer
test-base-mac:
runs-on: macos-latest
strategy:
Expand Down
5 changes: 0 additions & 5 deletions src/cp/hucocks.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -458,11 +458,6 @@ double HuCocksPrecipitationModel::dG_df(double f, double T) const
dc_eff += a;
}

// Get the effective equilibrium concentration
double ceq_eff = 1;
for (auto ci : ceq_)
ceq_eff *= ci->value(T);

return -kboltz_ * T / vm_ * dc_eff / c_eff;
}

Expand Down

0 comments on commit 5f08d7f

Please sign in to comment.