Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README #412

wants to merge 1 commit into from

Conversation

TrevPennington
Copy link

@TrevPennington TrevPennington commented Nov 8, 2022 •
edited
Loading

  • updated Arhia/action-check-typescript version to reference a real version (using @v2.0 fails the action because it does not exist)
  • updated explanation that the checker does run by default

@TrevPennington
Update README
3a46e36 
- updated Arhia/action-check-typescript version to reference a real version (using @v2.0 fails the action because it does not exist)
- updated explanation that the checker does run by default
abenhamdine
abenhamdine requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@abenhamdine abenhamdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR !
You are right for the action version.
However I don't think use-check is true by default : there's no default value for use-check in the action.yml file don't set a default value neither

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abenhamdine abenhamdine abenhamdine requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevPennington @abenhamdine