Improve unicode codepoint Bisearch performance #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the performance of the functions for searching for codepoints in a table by passing the table array in as a reference instead of copying it. This doesn't really improve the results of the benchmarks for some reason, but in my application with GCC8 i686, Intel Atom E3950 and a 180x60 terminal, this reduces the time for rendering a frame from ~31 ms to ~5.5 ms.
|
Wow! I can't believe this got unnoticed for so long. Thank you! I added a benchmark. I measured this improves debug performance by 3x and Release performance by 0x. I guess the compiler was able to optimize this function. |
|
Yeah, I'm guessing my older GCC8 for some reason isn't able to optimize it, but newer compilers probably are. I would guess that the compiler would see these as great in-lining candidates as it is only used inside the module, but at least GCC 8 with -O3 doesn't do that. |
ArthurSonzogni
added a commit
that referenced
this pull request
Jul 25, 2023
Improve the performance of the functions for searching for codepoints in a table by passing the table array in as a reference instead of copying it. Co-authored-by: ArthurSonzogni <sonzogniarthur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of the functions for searching for codepoints in a table by passing the table array in as a reference instead of copying it.
This doesn't really improve the results of the benchmarks for some reason, but in my application with GCC8 i686, Intel Atom E3950 and a 180x60 terminal, this reduces the time for rendering a frame from ~31 ms to ~5.5 ms.