Add -Wold-style-cast to FTXUI_DEV_WARNINGS #729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the -Wold-style-cast to the FTXUI_DEV_WARNINGS and fix the compiler complaints about C casts
StefanRvO
force-pushed
the
old_style_casts
branch
from
7a9aa0a
to
b2f1bef
Compare
|
Thank you! I like old style cast. So sorry, I would like not to merge this PR. Is there any reason embedders of FTXUI might need this? |
|
Ok, that is fair. Not really, other than if a codebase FTXUI is compiled into sets the -Wold-style-cast warning as default, as mine do, so i have to except that warning for FTXUI when i add it. But it is fine, not much of a hassle :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the -Wold-style-cast to the FTXUI_DEV_WARNINGS and fix the compiler complaints about C casts