Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-disk and resolve health error API #15

Open
wants to merge 14 commits into
base: Az.RecoveryServices_preview
Choose a base branch
from

Conversation

ayfathim
Copy link

@ayfathim ayfathim commented Sep 4, 2019

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@ayfathim ayfathim requested a review from viverm September 4, 2019 09:02
Copy link

@viverm viverm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Remove-ASRRecoveryPlan', 'Remove-ASRReplicationProtectedItem',
'Remove-ASRRecoveryPlan', 'Remove-ASRReplicationProtectedItem',
'Remove-ASRReplicationProtectedItemDisk',
'Remove-ASRReplicationProtectedItemHealthError',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve-ASRReplicationProtectedItemHealthError checking with PS team if that works fine .
then no need for -resourceId field

vidyadharijami pushed a commit that referenced this pull request Sep 17, 2023
Added exmple #15 which shows how to properly add or remove Availability zones to an Azure Firewall.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants