Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New api version/asr2021 02 10 #27

Merged
merged 38 commits into from
Apr 16, 2021
Merged

New api version/asr2021 02 10 #27

merged 38 commits into from
Apr 16, 2021

Conversation

nilgupta6
Copy link

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

nilgupta6 and others added 30 commits March 16, 2021 17:59
@nilgupta6
Merge pull request #16 from Azure/master
7a0ee9c 
bringing Asr one sdk azure- master in sync with master branch for azure/azure-powershell
@Arpitaji
Fixing PFO/TFO/UFO build errors
21a948e
@subashchandra31
mulltiple ip per nic - cmdlet changes
f39ee62
@subashchandra31
review changes
5451de4
@subashchandra31
code review changes
b3d874e
@subashchandra31
moved validaton to nicConfig cmdlet and review changes
c03880a
@subashchandra31
minor fix
5f80211
@subashchandra31
handled review comments
767e166
@subashchandra31
parameter validation changes, logs
b3da526
@subashchandra31
design review changes
a157e37
@subashchandra31
Merge pull request #18 from AsrOneSdk/multipleIPPerNicCmdletChanges
1c3f963 
Multiple IP per nic - cmdlet changes
@Arpitaji @nilgupta6
Fixing PFO/TFO/UFO build errors
2154cd0
@subashchandra31 @nilgupta6
mulltiple ip per nic - cmdlet changes
0a05b20 
review changes

code review changes

moved validaton to nicConfig cmdlet and review changes

minor fix

handled review comments

parameter validation changes, logs

design review changes
subash's multiple IP per NIC PR changes
@Arpitaji
Fixing B2A, E2A and E2E Tests and added recording
453790b
@Arpitaji
Merge pull request #20 from AsrOneSdk/arpita-powershell-march
3cedb24 
Fixing B2A, E2A and E2E Tests and added recording
@vidyadharijami
Merge branch 'newApiVersion/asr2021-02-10' of https://github.com/AsrO…
9e7af56 
…neSdk/azure-powershell into newApiVersion/asr2021-02-10
@vidyadharijami
[ASR][V2A/H2A] TargetVmSize, AvSet, Sql RP and ResourceTagging change…
bf9627a 
…s for V2A and H2A
@vidyadharijami
Minor fix
a776238
@nilgupta6
vmss changes -1
987ff16
@nilgupta6
2) vmss changes - MD files
3b79114
@vidyadharijami
Addressed review comments and added new tests and recordings for B2A
55f907e
@nilgupta6
vmss changes
e12e015
@vidyadharijami
Addressed review comments
838a284
@vidyadharijami
Minor fixes
8a9138d
@vidyadharijami
Added V2A tests and recordings
2d1a123
@nilgupta6
PR comments
5a91e2b
@nilgupta6
Update New-AzRecoveryServicesAsrReplicationProtectedItem.md
94f74c8
@nilgupta6
Merge pull request #22 from AsrOneSdk/dev/nilgupta/vmsschanges1
fc11807 
VMSS powerShell changes to common branch
@vidyadharijami
Minor Fix
3d45cad
@vidyadharijami
Merge changes of newApiVersion/asr2021-02-10 branch
d7920f9
vidyadharijami and others added 8 commits March 26, 2021 16:35
@vidyadharijami
Merge pull request #21 from AsrOneSdk/dev/vijami/V2AH2AChangesLatest
2d0bec1 
TargetVmSize, AvSet, Sql RP and ResourceTagging changes for V2A and H2A
@nilgupta6
Adding null for OdataQuery as its default value is also null.
7f5f694
@pradheepm
V2A test record json files
6578c3b
@pradheepm
Merge pull request #23 from AsrOneSdk/user/prmyaka/v2anewversiontest
28e2299 
V2A test record json files
@vidyadharijami
Fix for Resource Tagging to clear off tags
71de23e
@vidyadharijami
Merge pull request #24 from AsrOneSdk/dev/vijami/FixForClearingTagsFo…
f88afa3 
…rResource

[V2A / H2A] Fixed the resource tagging parameters to clear off tags case in Set(Update) ProtectedItem cmdlet
@pradheepm
Minor fix in playback mode for v2a unit tests
abcd7b5
@pradheepm
Merge pull request #26 from AsrOneSdk/user/prmyaka/v2aunittests
64e8985 
Minor fix in playback mode for v2a unit tests
@nilgupta6 nilgupta6 closed this Apr 16, 2021
@nilgupta6 nilgupta6 reopened this Apr 16, 2021
@nilgupta6 nilgupta6 merged commit 54b5afa into newApiVersion/asr2021-02-10-v2 Apr 16, 2021
nilgupta6 added a commit that referenced this pull request Apr 19, 2021
@nilgupta6 @Arpitaji
@subashchandra31 @vidyadharijami @pradheepm
New api version/asr2021 02 10 (#27)
74a6960 
* Fixing PFO/TFO/UFO build errors

* mulltiple ip per nic - cmdlet changes

* review changes

* code review changes

* moved validaton to nicConfig cmdlet and review changes

* minor fix

* handled review comments

* parameter validation changes, logs

* design review changes

* Fixing PFO/TFO/UFO build errors

* mulltiple ip per nic - cmdlet changes

review changes

code review changes

moved validaton to nicConfig cmdlet and review changes

minor fix

handled review comments

parameter validation changes, logs

design review changes
subash's multiple IP per NIC PR changes

* Fixing B2A, E2A and E2E Tests and added recording

* [ASR][V2A/H2A] TargetVmSize, AvSet, Sql RP and ResourceTagging changes for V2A and H2A

* Minor fix

* vmss changes -1

* 2) vmss changes - MD files

* Addressed review comments and added new tests and recordings for B2A

* vmss changes

* Addressed review comments

* Minor fixes

* Added V2A tests and recordings

* PR comments

* Update New-AzRecoveryServicesAsrReplicationProtectedItem.md

* Minor Fix

* Adding null for OdataQuery as its default value is also null.

* V2A test record json files

* Fix for Resource Tagging to clear off tags

* Minor fix in playback mode for v2a unit tests

Co-authored-by: Arpita Gupta <arpgup@microsoft.com>
Co-authored-by: subashchandra31 <subash.chandra@microsoft.com>
Co-authored-by: subashchandra31 <66659771+subashchandra31@users.noreply.github.com>
Co-authored-by: Arpitaji <78065343+Arpitaji@users.noreply.github.com>
Co-authored-by: Vidyadhari Jami <vijami@microsoft.com>
Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com>
Co-authored-by: prmyaka <prmyaka@microsoft.com>
imshashwataggarwal pushed a commit that referenced this pull request May 5, 2021
@nilgupta6 @Arpitaji
@subashchandra31 @vidyadharijami @pradheepm
Azure site recovery powershell release after moving to version 2021-0…
5e0f466 
…2-10 (Azure#14768)

* New api version/asr2021 02 10 (#27)

* Fixing PFO/TFO/UFO build errors

* mulltiple ip per nic - cmdlet changes

* review changes

* code review changes

* moved validaton to nicConfig cmdlet and review changes

* minor fix

* handled review comments

* parameter validation changes, logs

* design review changes

* Fixing PFO/TFO/UFO build errors

* mulltiple ip per nic - cmdlet changes

review changes

code review changes

moved validaton to nicConfig cmdlet and review changes

minor fix

handled review comments

parameter validation changes, logs

design review changes
subash's multiple IP per NIC PR changes

* Fixing B2A, E2A and E2E Tests and added recording

* [ASR][V2A/H2A] TargetVmSize, AvSet, Sql RP and ResourceTagging changes for V2A and H2A

* Minor fix

* vmss changes -1

* 2) vmss changes - MD files

* Addressed review comments and added new tests and recordings for B2A

* vmss changes

* Addressed review comments

* Minor fixes

* Added V2A tests and recordings

* PR comments

* Update New-AzRecoveryServicesAsrReplicationProtectedItem.md

* Minor Fix

* Adding null for OdataQuery as its default value is also null.

* V2A test record json files

* Fix for Resource Tagging to clear off tags

* Minor fix in playback mode for v2a unit tests

Co-authored-by: Arpita Gupta <arpgup@microsoft.com>
Co-authored-by: subashchandra31 <subash.chandra@microsoft.com>
Co-authored-by: subashchandra31 <66659771+subashchandra31@users.noreply.github.com>
Co-authored-by: Arpitaji <78065343+Arpitaji@users.noreply.github.com>
Co-authored-by: Vidyadhari Jami <vijami@microsoft.com>
Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com>
Co-authored-by: prmyaka <prmyaka@microsoft.com>

* Tests tested in playback mode

TestNewA2AManagedDiskReplicationConfigWithCmk
A2AZoneToZoneRecoveryPlanReplication
A2ATestNewContainer
A2ARemoveReplicationProtectedItemDisk
A2ARecoveryPlanReplication
A2ANewAsrFabric
vmss test

Adding tests

TestNewA2AManagedDiskReplicationConfig
TestNewA2ADiskReplicationConfig

adding ppg test for a2a

* help file, PSObject and minor fixes

* review comments

* null check

* updated test and test json

* updated changeLog

* skip common: v2a event test

* updating SDK version

* updating tests

* adding comments

* update online version in help files

* update help file

* adding breaking change exceptions

* updated help file

* changing breaking changes in reovery

* adding recovery service changes

* remove nupkg file

* removing vaultcreds

* adding recovery service changes

* remove nupkg file

* removing vaultcreds

* V2A test update for linux

* update V2A test

Co-authored-by: Arpita Gupta <arpgup@microsoft.com>
Co-authored-by: subashchandra31 <subash.chandra@microsoft.com>
Co-authored-by: subashchandra31 <66659771+subashchandra31@users.noreply.github.com>
Co-authored-by: Arpitaji <78065343+Arpitaji@users.noreply.github.com>
Co-authored-by: Vidyadhari Jami <vijami@microsoft.com>
Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com>
Co-authored-by: prmyaka <prmyaka@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nilgupta6 @Arpitaji @subashchandra31 @vidyadharijami @pradheepm