refactor: remove defaultErrorHandler

AthennaIO · Mar 30, 2022 · 95304ac · 95304ac
1 parent 642d513
commit 95304ac
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 79 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -160,7 +160,6 @@
   "dependencies": {
     "@athenna/config": "1.0.5",
     "@athenna/ioc": "1.0.6",
-    "@athenna/logger": "1.0.4",
     "@secjs/utils": "1.8.0",
     "fastify": "3.27.4",
     "reflect-metadata": "0.1.13",

diff --git a/src/Http.ts b/src/Http.ts
@@ -11,7 +11,6 @@ import fastify, { FastifyInstance, PrintRoutesOptions } from 'fastify'
 
 import { FastifyHandler } from './Utils/FastifyHandler'
 import { HttpMethodTypes } from './Contracts/HttpMethodTypes'
-import { defaultErrorHandler } from './Utils/defaultErrorHandler'
 import { HandlerContract } from './Contracts/Context/HandlerContract'
 import { MiddlewareTypesContract } from './Contracts/MiddlewareTypesContract'
 import { ErrorHandlerContract } from './Contracts/Context/Error/ErrorHandlerContract'
@@ -24,7 +23,6 @@ export class Http {
 
   constructor() {
     this.server = fastify()
-    this.setErrorHandler(defaultErrorHandler)
   }
 
   setErrorHandler(handler: ErrorHandlerContract) {

diff --git a/src/Utils/defaultErrorHandler.ts b/src/Utils/defaultErrorHandler.ts
diff --git a/tests/Unit/HttpTest.ts b/tests/Unit/HttpTest.ts
@@ -93,13 +93,9 @@ describe('\n HttpTest', () => {
     await errorHttp.close()
 
     expect(response.status).toBe(400)
-    expect(response.body.code).toStrictEqual('BAD_REQUEST_ERROR')
-    expect(response.body.path).toStrictEqual('/test')
-    expect(response.body.method).toStrictEqual('GET')
-    expect(response.body.status).toStrictEqual('ERROR')
     expect(response.body.statusCode).toStrictEqual(400)
-    expect(response.body.error.name).toStrictEqual('BadRequestException')
-    expect(response.body.error.message).toStrictEqual('Testing')
+    expect(response.body.code).toStrictEqual('BAD_REQUEST_ERROR')
+    expect(response.body.message).toStrictEqual('Testing')
   })
 
   it('should be able to register a new route with a intercept middleware', async () => {

diff --git a/tests/Unit/RouteTest.ts b/tests/Unit/RouteTest.ts
@@ -192,14 +192,10 @@ describe('\n RouteTest', () => {
       const response = await supertest('http://localhost:3044').get('/v1/test')
 
       expect(response.status).toBe(400)
-      expect(response.body.midHandler).toBeFalsy()
-      expect(response.body.code).toStrictEqual('BAD_REQUEST_ERROR')
-      expect(response.body.path).toStrictEqual('/v1/test')
-      expect(response.body.method).toStrictEqual('GET')
-      expect(response.body.status).toStrictEqual('ERROR')
       expect(response.body.statusCode).toStrictEqual(400)
-      expect(response.body.error.name).toStrictEqual('BadRequestException')
-      expect(response.body.error.message).toStrictEqual('Testing')
+      expect(response.body.code).toStrictEqual('BAD_REQUEST_ERROR')
+      expect(response.body.error).toStrictEqual('Bad Request')
+      expect(response.body.message).toStrictEqual('Testing')
     }
     {
       const response = await supertest('http://localhost:3044').patch('/v1/test')