This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
fix ignoreFixableRulesWhileTyping #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `cliEngine` does not have `getRules` among its own properties, instead the function is a class method. Because of this, the `getRules` function in `worker-helpers.js` would just return an empty map and `ignoreFixableRulesWhileTyping` couldn't work.
|
I've fixed “CI / CommitLint (pull_request)”; the problem with “CI / Lint (pull_request)” does not seem like something I can affect, please advise. |
UziTech
approved these changes
Apr 13, 2021
|
The CI / Lint issue is a known issue unrelated to these changes. |
|
🎉 This PR is included in version 8.6.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting
ignoreFixableRulesWhileTypingcurrently doesn't work.A
cliEnginedoes not havegetRulesamong its own properties, instead the function is a class method. Because of this, thegetRulesfunction inworker-helpers.jswould just return an empty map andignoreFixableRulesWhileTypingcannot know what rules to ignore.This PR fixes that, now fixable rules are nicely ignored while typing.