Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dplug-build Windows Installer #361

Merged
merged 15 commits into from
May 27, 2019
Merged

dplug-build Windows Installer #361

merged 15 commits into from
May 27, 2019

Conversation

abaga129
Copy link
Contributor

This adds support for the --installer flag in dplug-build on Windows.

Requirements

  • Windows 10 SDK (must append path to signtool.exe to PATH variable)
  • NSIS (must append path to makensis.exe to PATH variable)

Features

  • works with all current plugin formats
  • Ability for user to choose which "Components" to install
  • Ability for user to set install directory for VST 32bit and VST 64bit
  • Uses signtool from the Windows SDK to sign the resulting .exe
  • custom header bmp image

plugin.json additions

The windows installer uses the following fields in plugin.json

windowsInstallerHeaderBmp - optional 150x57 bmp image to use in the header

keyFile-windows - Path to PFX keyfile. Duplicated from pace.json

keyPassword-windows - Password for PFX keyfile. Duplicated from pace.json

Looking forward to review!

@p0nce
Copy link
Collaborator

p0nce commented May 27, 2019

OK my review only contains the following:

  • for LV2 bitness of dplug-build indeed says whether we can generate 32-bit LV2 or 64-bit LV2, however up to now I've considered that we just say we don't support 32-bit LV2. You can just assume a 64-bit dplug-build unless you are interested in Windows + 32-bit + LV2 format. So I'd say to not bother.

  • I'm not sure the --installer will work if we build only & 64-bit VST, it will still propose both versions, but that's not bothering to me as that case will not happen for a long while.

So, I'm ready to merge without changes.

@p0nce p0nce merged commit 9046d7d into AuburnSounds:master May 27, 2019
@p0nce p0nce mentioned this pull request May 27, 2019
@abaga129
Copy link
Contributor Author

I can work on those two cases and make a follow up PR. I think only supporting 64bit LV2 is a good idea. We could see if there is a way to gray out AAX and LV2 if the installer is being run on a 32bit machine. Then we can skip installing those formats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants