Skip to content

Commit

Permalink
Lock file maintenance (#38822)
Browse files Browse the repository at this point in the history
* Lock file maintenance
* Phan: Suppress PhanDeprecatedImplicitNullableParam when supporting PHP 7.0
* Fix new Phan issues
  * PhanDeprecatedImplicitNullableParam in plugins/crm
  * Calls passing string to `update_option()` `$autoload`, which in WP 6.6
    was changed to bool (but silently still accepting string for back
    compat).
* Update phan baselines
* Phan: WP 6.6 fixed a phpdoc which removes something from the baseline, but we still need a suppression for the WP 6.5 compat run.

---------

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com>
  • Loading branch information
3 people committed Aug 15, 2024
1 parent 7015560 commit cf8996c
Show file tree
Hide file tree
Showing 79 changed files with 1,772 additions and 1,760 deletions.
6 changes: 6 additions & 0 deletions .phan/config.base.php
Original file line number Diff line number Diff line change
Expand Up @@ -268,5 +268,11 @@ function make_phan_config( $dir, $options = array() ) {
$config['minimum_target_php_version'] = $m[1];
}

// Disable PhanDeprecatedImplicitNullableParam if still supporting PHP 7.0
// @todo Remove this once we drop PHP 7.0 support everywhere.
if ( isset( $config['minimum_target_php_version'] ) && version_compare( $config['minimum_target_php_version'], '7.1.0', '<' ) ) {
$config['suppress_issue_types'][] = 'PhanDeprecatedImplicitNullableParam';
}

return $config;
}
115 changes: 62 additions & 53 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit cf8996c

Please sign in to comment.