-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assets: Fix defer for async scripts #23928
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
5c600b8
to
6aa0381
Compare
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Thanks for the feedback @anomiex! I've addressed it and added several comments to suppress false positive phpcs errors. Ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go for it
I've noticed that whenever we register a script as
async
, it will add adefer
attribute to the translations script tag that is rendered before the enqueued script tag.This PR fixes that behavior so we defer the script we enqueued instead.
I'm also adding a couple of tests to confirm that the behavior is working as expected.
Changes proposed in this Pull Request:
Assets: Defer the enqueued script instead of its translations
Jetpack product discussion
No related product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
async => true
to a script you register,defer
will be added to the script and not to its translations.