Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Disable debug logs when running unit tests #30540

Merged
merged 2 commits into from
May 12, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 9, 2023

Related to wordpress-mobile/gutenberg-mobile#5734.

⚠️ This PR depends on #30486.

Proposed changes:

  • Prevent enabling debug logs for VideoPress when running unit tests.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

Debug logs are disabled in unit tests

Debug logs are enabled in development mode

  • Run the app and connect it with the local Metro server (i.e. development mode).
  • Add a VideoPress block and add a video.
  • Observe that VideoPress debug logs are printed.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack rnmobile/videopress-disable-debug-logs-on-tests

to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@fluiddot fluiddot force-pushed the rnmobile/videopress-disable-debug-logs-on-tests branch from 4778fe3 to 60e4f2d Compare May 9, 2023 11:06
@fluiddot fluiddot changed the base branch from trunk to rnmobile/videopress-add-test-ids May 9, 2023 11:06
Base automatically changed from rnmobile/videopress-add-test-ids to trunk May 10, 2023 08:34
@fluiddot fluiddot force-pushed the rnmobile/videopress-disable-debug-logs-on-tests branch from 60e4f2d to fc5db4c Compare May 10, 2023 14:51
Copy link

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot, LGTM! No unexpected side effects in my testing. It looks like this PR just needs updating from trunk for the tests to pass, happy to re-approve if this one gets dismissed as part of that.

@fluiddot fluiddot force-pushed the rnmobile/videopress-disable-debug-logs-on-tests branch from fc5db4c to 62577cc Compare May 12, 2023 08:40
@fluiddot fluiddot added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels May 12, 2023
@fluiddot fluiddot enabled auto-merge (squash) May 12, 2023 08:53
@fluiddot fluiddot merged commit e391489 into trunk May 12, 2023
@fluiddot fluiddot deleted the rnmobile/videopress-disable-debug-logs-on-tests branch May 12, 2023 09:04
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants