Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QueryCursor): eachAsync parameter of AggregationCursor and QueryCursor #14299

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

DevooKim
Copy link
Contributor

Summary

Currently, documentation for QueryCursor.prototype.eachAsync write that it takes a callback as a parameter.

However, with the update to version 7, eachAsync no longer supports callbacks. - Show commits
So, I fix parameters of eachAsync and the migrating guide to 7.

it has two more changes.

  1. Add AggregationCursor.prototype.next, which was missing the guide.
  2. fix conditional statements conditional in QueryCursor.prototype.next

@DevooKim DevooKim changed the title Fix eachAsync parameter for AggregationCursor and QueryCursor Fix eachAsync parameter of AggregationCursor and QueryCursor Jan 26, 2024
@DevooKim DevooKim changed the title Fix eachAsync parameter of AggregationCursor and QueryCursor fix(eachAsync): eachAsync parameter of AggregationCursor and QueryCursor Jan 26, 2024
@DevooKim DevooKim changed the title fix(eachAsync): eachAsync parameter of AggregationCursor and QueryCursor fix(QueryCursor): eachAsync parameter of AggregationCursor and QueryCursor Jan 26, 2024
@vkarpov15 vkarpov15 added this to the 8.1.2 milestone Jan 26, 2024
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 8ef0d9a into Automattic:master Jan 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants