Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(cursor): indicate that cursor.next() can return null #14798

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14787

Summary

await cursor.next() will be null if there's no more docs

Examples

@vkarpov15 vkarpov15 added this to the 8.5.3 milestone Aug 8, 2024
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Aug 9, 2024
@vkarpov15 vkarpov15 merged commit 4fa87e9 into master Aug 10, 2024
5 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14787 branch August 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor.next can return null, but TypeScript says it can't
3 participants