Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Posts Block: Lists missing margins #28

Closed
alaczek opened this issue Dec 22, 2017 · 2 comments
Closed

Latest Posts Block: Lists missing margins #28

alaczek opened this issue Dec 22, 2017 · 2 comments
Assignees

Comments

@alaczek
Copy link
Contributor

alaczek commented Dec 22, 2017

If the Latest Posts block is used in conjunction with "align center" option, the list is not indented properly because of this core Gutenberg style:

.aligncenter {
    clear: both;
    display: block;
    margin-left: auto;
    margin-right: auto;
}

The other alignment options look weird too, but I think this falls outside of theme scope.

image

@laurelfulford
Copy link
Contributor

Yeah, that looks terrible 😄

What do you think a good fix is for this? Maybe reinstating the margins, and just aligning text centre?

@laurelfulford laurelfulford self-assigned this Jan 3, 2018
laurelfulford added a commit that referenced this issue Jan 4, 2018
…don't clash with the wide and full Gutenberg widths. See #28.
@laurelfulford
Copy link
Contributor

I switched the lists to use padding instead of margins for indent so they no longer get overridden by Gutenberg's styles.

There's still some weirdness with the full and wide alignments because of this issue: WordPress/gutenberg#4015 (the .columns-3 class is always added to Latest Posts block).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants