Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia: Remove Jetpack Dependency For Featured Images #7568

Closed

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented Dec 20, 2023

Changes proposed in this Pull Request:

@pbking - this is how I'd go about #7566 :) Up to you if you'd prefer it to #7567, but here's the advantages.

Pros:
A lot of the reports in Automattic/wp-calypso#85369 were about the fact that Content Options automatically hides the Featured Images set in the Latest Posts block. There is an open issue in Jetpack about this - Automattic/jetpack#29286 - but I tried fixing it, and it seems super tricky to do. This would at least remove Varia from the list of themes affected by that bug.

Also doesn't require Jetpack anymore, but I don't think that's a problem - can't imagine many self-hosted sites without Jetpack using Varia, to be honest.

Cons:
User who have made changes in the last two weeks for the Posts and Blog settings will need to do so again.

Feel free to close if, in your judgement, the cons outweigh the pros here.

Related issue(s):

Closes Automattic/wp-calypso#85369

@pbking
Copy link
Contributor

pbking commented Dec 20, 2023

Ooh I like it!

Giving this a solid test. Hadn't quite yet shipped the alternative yet.

@pbking
Copy link
Contributor

pbking commented Dec 20, 2023

Thank you @Aurorum I checked this branch out. It's not behaving quite like I was expecting. Images aren't shown in situations where I expect them to. I think it could ultimately be made to work and not having the Jetpack dependency would be great but it's not there and with the many child themes that varia has might not be the most efficient fix.

I'm going to close this one and go with the #7567 option instead; it works as expected as I stepped through the timeline of changes as a customer.

Thank you for your help and for presenting another option.

@pbking pbking closed this Dec 20, 2023
@Aurorum
Copy link
Contributor Author

Aurorum commented Dec 20, 2023

No worries at all, that makes sense! Glad to have a solution which fixes Automattic/wp-calypso#85369 while still giving users control of their Featured Images. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Featured Images defaulting ON for pages and posts in Varia and Varia child themes.
2 participants