Varia: Remove Jetpack Dependency For Featured Images #7568
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
@pbking - this is how I'd go about #7566 :) Up to you if you'd prefer it to #7567, but here's the advantages.
Pros:
A lot of the reports in Automattic/wp-calypso#85369 were about the fact that Content Options automatically hides the Featured Images set in the Latest Posts block. There is an open issue in Jetpack about this - Automattic/jetpack#29286 - but I tried fixing it, and it seems super tricky to do. This would at least remove Varia from the list of themes affected by that bug.
Also doesn't require Jetpack anymore, but I don't think that's a problem - can't imagine many self-hosted sites without Jetpack using Varia, to be honest.
Cons:
User who have made changes in the last two weeks for the Posts and Blog settings will need to do so again.
Feel free to close if, in your judgement, the cons outweigh the pros here.
Related issue(s):
Closes Automattic/wp-calypso#85369