Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exmoor: updates for the theme review #7628

Merged
merged 1 commit into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exmoor/functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @since Exmoor 1.0
*/

declare( strict_types = 1 );

if ( ! function_exists( 'exmoor_support' ) ) :

Expand Down
3 changes: 3 additions & 0 deletions exmoor/patterns/404.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* Slug: exmoor/404
* Inserter: no
*/

declare( strict_types = 1 );
?>

<!-- wp:heading {"textAlign":"left","level":1,"fontSize":"medium","anchor":"oops-that-page-can-t-be-found"} -->
<h1 class="wp-block-heading has-text-align-left has-medium-font-size" id="oops-that-page-can-t-be-found"><?php echo esc_html__( 'Oops! That page can’t be found.', 'exmoor' ); ?></h1>
<!-- /wp:heading -->
Expand Down
3 changes: 3 additions & 0 deletions exmoor/patterns/call-to-action.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* Slug: exmoor/call-to-action
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"full","style":{"spacing":{"margin":{"top":"0","bottom":"0"},"padding":{"top":"8vw","bottom":"8vw","right":"var:preset|spacing|60","left":"var:preset|spacing|60"}}},"backgroundColor":"secondary","layout":{"type":"constrained"}} -->
<div class="wp-block-group alignfull has-secondary-background-color has-background" style="margin-top:0;margin-bottom:0;padding-top:8vw;padding-right:var(--wp--preset--spacing--60);padding-bottom:8vw;padding-left:var(--wp--preset--spacing--60)">
<!-- wp:heading {"textAlign":"center","level":3,"style":{"typography":{"textTransform":"uppercase"}},"fontSize":"small"} -->
Expand Down
3 changes: 3 additions & 0 deletions exmoor/patterns/footer.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
* Categories: footer
* Block Types: core/template-part/footer
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"8vw","right":"var:preset|spacing|60","bottom":"8vw","left":"var:preset|spacing|60"},"margin":{"top":"0","bottom":"0"}}},"backgroundColor":"contrast","textColor":"base","layout":{"type":"constrained"}} -->
<div class="wp-block-group alignfull has-base-color has-contrast-background-color has-text-color has-background" style="margin-top:0;margin-bottom:0;padding-top:8vw;padding-right:var(--wp--preset--spacing--60);padding-bottom:8vw;padding-left:var(--wp--preset--spacing--60)">
<!-- wp:columns {"align":"wide"} -->
Expand Down
2 changes: 2 additions & 0 deletions exmoor/patterns/front-page.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Categories: hidden
* Inserter: no
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"tagName":"main","style":{"spacing":{"blockGap":"1.5rem"}},"layout":{"type":"constrained"}} -->
Expand Down
5 changes: 4 additions & 1 deletion exmoor/patterns/header.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@
* Categories: header
* Block Types: core/template-part/header
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"wide","layout":{"type":"constrained"}} -->
<div class="wp-block-group alignwide">
<!-- wp:group {"align":"wide","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50"}}},"textColor":"contrast","layout":{"type":"flex","flexWrap":"nowrap","justifyContent":"space-between","verticalAlignment":"stretch"}} -->
<div class="wp-block-group alignwide has-contrast-color has-text-color" style="padding-top:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50)">
<!-- wp:site-title /-->

<!-- wp:group {"layout":{"type":"flex","flexWrap":"nowrap","verticalAlignment":"top"}} -->
<!-- wp:group {"layout":{"type":"flex","flexWrap":"nowrap","verticalAlignment":"center"}} -->
<div class="wp-block-group">
<!-- wp:navigation {"style":{"spacing":{"blockGap":"var:preset|spacing|50"},"typography":{"fontStyle":"normal","fontWeight":"500"}}} /-->

Expand Down
3 changes: 3 additions & 0 deletions exmoor/patterns/heading-paragraph-four-columns.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* Slug: exmoor/heading-paragraph-four-columns
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"full","style":{"spacing":{"margin":{"top":"0","bottom":"0"},"padding":{"top":"8vw","bottom":"8vw","right":"var:preset|spacing|60","left":"var:preset|spacing|60"}}},"backgroundColor":"secondary","layout":{"type":"constrained"}} -->
<div class="wp-block-group alignfull has-secondary-background-color has-background" style="margin-top:0;margin-bottom:0;padding-top:8vw;padding-right:var(--wp--preset--spacing--60);padding-bottom:8vw;padding-left:var(--wp--preset--spacing--60)">
<!-- wp:group {"align":"wide","layout":{"type":"constrained","justifyContent":"left"}} -->
Expand Down
3 changes: 3 additions & 0 deletions exmoor/patterns/heading-table.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* Slug: exmoor/heading-table
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"full","style":{"spacing":{"margin":{"top":"0","bottom":"0"},"padding":{"top":"8vw","bottom":"8vw","right":"var:preset|spacing|60","left":"var:preset|spacing|60"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group alignfull" style="margin-top:0;margin-bottom:0;padding-top:8vw;padding-right:var(--wp--preset--spacing--60);padding-bottom:8vw;padding-left:var(--wp--preset--spacing--60)">
<!-- wp:group {"align":"wide","layout":{"type":"constrained","justifyContent":"left"}} -->
Expand Down
2 changes: 2 additions & 0 deletions exmoor/patterns/hero.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Slug: exmoor/hero
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:cover {"url":"<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/StockSnap_K6K80SHQJO-cropped.jpg","dimRatio":0,"focalPoint":{"x":0.7,"y":1},"minHeight":480,"minHeightUnit":"px","contentPosition":"center center","align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|60","left":"var:preset|spacing|60","bottom":"8vw","top":"8vw"}}}} -->
Expand Down
6 changes: 4 additions & 2 deletions exmoor/patterns/masthead.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Slug: exmoor/masthead
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"wide","style":{"spacing":{"margin":{"top":"0","bottom":"0"}}},"layout":{"type":"constrained"}} -->
Expand All @@ -16,8 +18,8 @@
<div class="wp-block-columns alignwide are-vertically-aligned-bottom">
<!-- wp:column {"verticalAlignment":"bottom","width":"72%"} -->
<div class="wp-block-column is-vertically-aligned-bottom" style="flex-basis:72%">
<!-- wp:heading {"level":1,"align":"wide","style":{"typography":{"lineHeight":"0.8","textTransform":"uppercase","fontStyle":"normal","fontWeight":"900"}},"fontSize":"huge","fontFamily":"raleway"} -->
<h1 class="wp-block-heading alignwide has-raleway-font-family has-huge-font-size" style="font-style:normal;font-weight:900;line-height:0.8;text-transform:uppercase"><?php echo wp_kses_post( __( 'Your<br>journey<br>begins', 'exmoor' ) ); ?></h1>
<!-- wp:heading {"level":1,"align":"wide","style":{"typography":{"lineHeight":"0.8","textTransform":"uppercase","fontStyle":"normal","fontWeight":"900"}},"fontSize":"xxxx-large","fontFamily":"raleway"} -->
<h1 class="wp-block-heading alignwide has-raleway-font-family has-xxxx-large-font-size" style="font-style:normal;font-weight:900;line-height:0.8;text-transform:uppercase"><?php echo wp_kses_post( __( 'Your<br>journey<br>begins', 'exmoor' ) ); ?></h1>
<!-- /wp:heading -->
</div>
<!-- /wp:column -->
Expand Down
3 changes: 3 additions & 0 deletions exmoor/patterns/no-results-content.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* Slug: exmoor/no-results-content
* Inserter: no
*/

declare( strict_types = 1 );
?>

<!-- wp:paragraph -->
<p><?php echo esc_html_x( 'Sorry, but nothing matched your search terms. Please try again with some different keywords.', 'Message explaining that there are no results returned from a search', 'exmoor' ); ?></p>
<!-- /wp:paragraph -->
3 changes: 3 additions & 0 deletions exmoor/patterns/paragraph.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* Slug: exmoor/paragraph
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"full","style":{"spacing":{"margin":{"top":"0","bottom":"0"},"padding":{"top":"8vw","bottom":"8vw","right":"var:preset|spacing|60","left":"var:preset|spacing|60"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group alignfull" style="margin-top:0;margin-bottom:0;padding-top:8vw;padding-right:var(--wp--preset--spacing--60);padding-bottom:8vw;padding-left:var(--wp--preset--spacing--60)">
<!-- wp:group {"align":"wide","layout":{"type":"constrained","justifyContent":"right"}} -->
Expand Down
2 changes: 2 additions & 0 deletions exmoor/patterns/search.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Slug: exmoor/search
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:search {"label":"","showLabel":false,"placeholder":"<?php echo esc_html_x( 'Search...', 'This is a placeholder text in a search field', 'exmoor' ); ?>","buttonPosition":"button-inside","buttonUseIcon":true} /-->
3 changes: 3 additions & 0 deletions exmoor/patterns/small-heading-quote.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* Slug: exmoor/small-heading-quote
* Categories: featured
*/

declare( strict_types = 1 );
?>

<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"8vw","right":"var:preset|spacing|60","bottom":"8vw","left":"var:preset|spacing|60"},"margin":{"top":"0","bottom":"0"}}},"backgroundColor":"contrast","textColor":"base","layout":{"type":"constrained"}} -->
<div class="wp-block-group alignfull has-base-color has-contrast-background-color has-text-color has-background" style="margin-top:0;margin-bottom:0;padding-top:8vw;padding-right:var(--wp--preset--spacing--60);padding-bottom:8vw;padding-left:var(--wp--preset--spacing--60)">
<!-- wp:columns {"align":"wide"} -->
Expand Down
2 changes: 1 addition & 1 deletion exmoor/readme.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
=== Exmoor ===
Contributors: Automattic
Requires at least: 6.0
Tested up to: 6.2
Tested up to: 6.4
Requires PHP: 5.7
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Expand Down
39 changes: 19 additions & 20 deletions exmoor/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,28 @@ Author: Automattic
Author URI: https://automattic.com/
Description: Exmoor is a business theme
Requires at least: 6.0
Tested up to: 6.2
Tested up to: 6.4
Requires PHP: 5.7
Version: 1.0.4
License: GNU General Public License v2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Text Domain: exmoor
Tags: blog, holiday, one-column, two-columns, wide-blocks, block-patterns, custom-background, custom-colors, custom-logo, custom-menu, editor-style, featured-images, full-site-editing, rtl-language-support, template-editing, threaded-comments, translation-ready, style-variations
Tags: holiday, one-column, wide-blocks, block-patterns,featured-images, full-site-editing, rtl-language-support, threaded-comments, translation-ready, style-variations
Status: inactive
*/

/*
* Button Block
* Control the hover stylings of outline block style.
* Unnecessary once block styles are configurable via theme.json
* https://github.com/WordPress/gutenberg/issues/42794
*/
.wp-block-button.is-style-outline>.wp-block-button__link:not(.has-background):hover {
background-color: var(--wp--preset--color--primary);
color: var(--wp--preset--color--base);
border-color: var(--wp--preset--color--primary);
}

/*
* Link styles
* https://github.com/WordPress/gutenberg/issues/42319
Expand All @@ -25,25 +37,12 @@ a {
}

/*
* Avatar Block
* Fix border radius setting for the avatar block
* https://github.com/WordPress/gutenberg/issues/48253
* Navigation Block
* Reset the padding from List block
* https://github.com/WordPress/gutenberg/issues/50486
*/
.wp-block-avatar a,
.wp-block-avatar img {
border-radius: inherit;
}

/*
* Button Block
* Control the hover stylings of outline block style.
* Unnecessary once block styles are configurable via theme.json
* https://github.com/WordPress/gutenberg/issues/42794
*/
.wp-block-button.is-style-outline>.wp-block-button__link:not(.has-background):hover {
background-color: var(--wp--preset--color--primary);
color: var(--wp--preset--color--base);
border-color: var(--wp--preset--color--primary);
.wp-block-navigation ul {
padding: unset;
}

/*
Expand Down
Loading
Loading