Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions/upload-artifact@v4 #2813

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

waclawjacek
Copy link
Contributor

@waclawjacek waclawjacek commented Sep 11, 2024

Description

Our QIT tests are currently failing. This is because GH Actions no longer support actions/upload-artifact@v1 that the workflow is using. Background: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

This PR replaces usage of v1 with the newest v4.

Steps to reproduce & screenshots/GIFs

  1. Try triggering a QIT run on trunk and see it fail.
  2. Look at the test status on this PR and see that it is successful.

@waclawjacek waclawjacek changed the title Use actions/upload-artifact@v2 Use actions/upload-artifact@v4 Sep 11, 2024
@waclawjacek waclawjacek self-assigned this Sep 11, 2024
@waclawjacek waclawjacek requested review from a team and kallehauge and removed request for a team September 11, 2024 10:15
@waclawjacek waclawjacek marked this pull request as ready for review September 11, 2024 10:15
@waclawjacek waclawjacek merged commit 5c73f27 into trunk Sep 11, 2024
9 checks passed
@waclawjacek waclawjacek deleted the use-gh-actions-upload-artifact-v2 branch September 11, 2024 10:21
@waclawjacek waclawjacek removed the request for review from kallehauge September 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant