Sharing: Update Disconnect buttons to use Borderless Button #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alternatekev
added
[Feature] Sharing
| @@ -1,12 +1,15 @@ | |||
| /** | |||
| * External dependencies | |||
| */ | |||
| var React = require( 'react' ); | |||
| var React = require( 'react' ), | |||
There was a problem hiding this comment.
Maybe we can take the time here to change these require lines to imports
mtias
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
@alternatekev before merging, do you mind squashing this into a single commit so we can keep history more sane? |
| @@ -249,6 +249,11 @@ $color-print: #f8f8f8; | |||
| border-color: lighten( $alert-yellow, 8% ) !important; | |||
| } | |||
| } | |||
|
|
|||
| &.is-compact{ | |||
There was a problem hiding this comment.
Nothing, it looks like an error. I cannot for the life of me figure out why it's there. Will remove.
rickybanister
changed the title
alternatekev
force-pushed
the
update/sharing-connect-buttons
branch
from
e2c6146
to
888c217
Compare
This was referenced Dec 10, 2015
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Sharing looks like this:
Those Disconnect buttons aren't standard to the RemoveButton pattern, so I've updated them here: