Domains: Cleanup Domain Management data components #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Status] In Progress
[Feature Group] Emails & Domains
gziolo
force-pushed
the
update/domains-data-components-cleanup
branch
from
01003ce
to
3ace0b6
Compare
gziolo
added
[Status] Needs Review
| context={ context } | ||
| productsList={ productsList } | ||
| sites={ sites }> | ||
| <DomainManagement.AddGoogleApps | ||
| productsList={ productsList } |
There was a problem hiding this comment.
productsList is now no longer passed to AddGoogleApps - but it seems that it does not need it. So all good, but it got me worried for a while
There was a problem hiding this comment.
Yes, that's true. Looks like copy and paste issue.
|
Code looks good and I did not find any bugs while I clicked through domain management. 👍 |
janm6k
added
[Status] Ready to Merge
and removed
[Status] Needs Review
gziolo
force-pushed
the
update/domains-data-components-cleanup
branch
from
3ace0b6
to
3e6e22d
Compare
gziolo
added a commit
that referenced
this pull request
Dec 10, 2015
…ts-cleanup Domains: Cleanup Domain Management data components
This was referenced Nov 18, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes cleanup in Domain Management data components. It makes sure there is only one way to pass child component to data component. It also moves user dependency from controller to data component.
Initially I wanted also to move
productListandsitesfrom controller to data components, but there is legacyobservemixin logic involved. I'm leaving it for further refactoring.Testing
There is really nothing special to test it. All Domain Management pages should work without any visible changes.
/cc @stephanethomas - we talked about those kind of changes a few weeks ago :)