Domain Management: Add onclick back for the privacy protection compact notice #1740
Conversation
breezyskies
added
[Status] Needs Review
| context: 'An icon label when Privacy Protection is enabled.' | ||
| } ) } | ||
| </Notice> | ||
| <a href="#" onClick={ this.goToPrivacyProtection }> |
There was a problem hiding this comment.
We shouldn't wrap with the link when there is privacy protection enabled. This page won't load in such case.
There was a problem hiding this comment.
The link worked fine for me -- just takes me to /domains/manage/:domain/contacts-privacy/:site. Any reason we shouldn't consistently link to it?
There was a problem hiding this comment.
In that case we should use this path domainManagementContactsPrivacy for privacy protection enabled, because at the moment we have redirect in between.
gziolo
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
breezyskies
force-pushed
the
fix/privacy-notice-link
branch
from
0da0c81
to
f6fc426
Compare
breezyskies
added
[Status] Needs Review
gziolo
force-pushed
the
fix/privacy-notice-link
branch
from
f6fc426
to
99f867e
Compare
|
I noticed that there was # added to the url when user clicks on None button. I added commit with fix. Now this should be ready to merge. I tested it and work properly in all cases :) |
gziolo
added
[Status] Ready to Merge
and removed
[Status] Needs Review
breezyskies
force-pushed
the
fix/privacy-notice-link
branch
from
99f867e
to
0a6650f
Compare
Domain Management: Add onclick back for the privacy protection compact notice
Updates the Privacy Protection on/off compact notices (shown below) so they correctly click through to the privacy settings page.
cc: @gziolo who raised this issue in #1676 (comment).