Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: use correct command for help shortcut #1746

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Editor: use correct command for help shortcut #1746

merged 1 commit into from
Dec 17, 2015

Conversation

lancewillett
Copy link
Contributor

Fixes #1457

To test:

  • Open up a post or page in Calypso editor
  • Use your keyboard to open the Help shortcuts menu with Control-Option-h on Mac OS X You should see this:
    screen shot 2015-12-17 at 11 17 17
  • And using Esc key or hitting Close button at bottom right of the window should close it.

@lancewillett lancewillett added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 17, 2015
@lancewillett
Copy link
Contributor Author

Ping @aduth for a review.

@lancewillett lancewillett mentioned this pull request Dec 17, 2015
Merged
@aduth
Copy link
Contributor

aduth commented Dec 17, 2015

👍

The button name and classes still use wp_help which feels a bit inconsistent, though I can confirm the changes here resolve the immediate problem.

@aduth aduth added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 17, 2015
lancewillett added a commit that referenced this pull request Dec 17, 2015
@lancewillett
Merge pull request #1746 from Automattic/fix/1457-help-shortcut
3b9e546 
Editor: use correct command for help shortcut
@lancewillett lancewillett merged commit 3b9e546 into master Dec 17, 2015
@lancewillett lancewillett deleted the fix/1457-help-shortcut branch December 17, 2015 23:07
@lancewillett lancewillett mentioned this pull request Dec 21, 2015
Merged
@awaisab172 awaisab172 mentioned this pull request May 11, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor: can't open shortcuts menu with Control-Option-H as expected
3 participants
@lancewillett @aduth @scruffian