Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts: status noticon replacement #2338

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Conversation

adambbecker
Copy link
Contributor

On post cards displayed in /posts/*, changed the status icons from noticons to gridicon components. Updated the size to the standard 18px as well as switching a few specific status to more appropriate icon types.

Before After
before after

Testing

  1. Visit /posts or any subsequent subpage that contains posts like scheduled, trashed, etc.
  2. Check that the icons in the lower left of the card (time icon, status icon, etc.) are visible and 18px size.
  3. Some specific status will now utilize more appropriate icons rather than just the "page" noticon:
    • General/Default: aside
    • Sticky: bookmark-outline
    • Scheduled: calendar
    • Trashed: trash

/cc @mattmiklic, @rickybanister

On post cards displayed in /posts/*, changed the status icons from noticons to gridicon components. Also switched a few specific status to appropriate icon types.
@adambbecker adambbecker added Posts [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Jan 12, 2016
@adambbecker adambbecker self-assigned this Jan 12, 2016
@adambbecker adambbecker added this to the Core: Iteration 17 milestone Jan 12, 2016
@rickybanister
Copy link

Those look great. I do notice that the trashed status has a delete button beneath it. I assume that's like extra-permanent-delete, but the status indicator is red (scarier in my mind) than the blue delete-for-all-eternity link. It's a separate issue, but while here I thought I'd mention it. I think one solution would be to make the 'delete' link and icon also red and make it say 'Delete Permanently'.

@adambbecker
Copy link
Contributor Author

@rickybanister: Awesome, and yes completely agree on the 'Delete Permanently' idea. I'll throw that onto another PR to keep this particular one focused on the icons.

mattmiklic added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Jan 12, 2016
mattmiklic added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Jan 12, 2016
Changing status label text colors to match the icons and labels in
Calypso. Automattic/wp-calypso#2338
@adambbecker
Copy link
Contributor Author

@rickybanister, @mattmiklic: After looking at a few of these a bit, I realized something about a few of the "status indicators" in that some of them are quite redundant and unnecessary. Specifically the trashed, & scheduled statuses.

Since those particular statuses are basically filters, it seems a bit redundant to also list them on the post card when the entire feed is that status. What you think of trimming down the status indicators to only apply on posts which could exist in a feed surrounded by other post types?

This would apply to the following types of statuses: sticky, pending review, etc. Basically only use status indicators when the post is actually a different status from the standard type in the feed you're currently looking at.

Few examples:

Scheduled
screen shot 2016-01-12 at 3 02 37 pm

Trashed
screen shot 2016-01-12 at 3 02 52 pm
Note: working on the Delete Permanently text in #2344

mattmiklic added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Jan 12, 2016
These are still in flux in Calypso, so not changing them for now. See
Automattic/wp-calypso#2338
@rickybanister
Copy link

I suppose it could get annoying if you had already filtered, BUT if you forgot you're viewing a filter you might miss that a post is trashed or scheduled (without looking at the other context clues). I can go either way on this—since it doesn't take up much space I'd probably leave the status indicators as they were, but don't have too much skin in the game.

One other language nitpick I noticed—should the 'publish' button be 'Publish Now' for scheduled posts? Is that easy enough to conditionalize?

@gwwar
Copy link
Contributor

gwwar commented Jan 14, 2016

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants