-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts: status noticon replacement #2338
Conversation
On post cards displayed in /posts/*, changed the status icons from noticons to gridicon components. Also switched a few specific status to appropriate icon types.
Those look great. I do notice that the trashed status has a delete button beneath it. I assume that's like extra-permanent-delete, but the status indicator is red (scarier in my mind) than the blue delete-for-all-eternity link. It's a separate issue, but while here I thought I'd mention it. I think one solution would be to make the 'delete' link and icon also red and make it say 'Delete Permanently'. |
@rickybanister: Awesome, and yes completely agree on the 'Delete Permanently' idea. I'll throw that onto another PR to keep this particular one focused on the icons. |
To match the latest in Calypso: Automattic/wp-calypso#2338
Changing status label text colors to match the icons and labels in Calypso. Automattic/wp-calypso#2338
@rickybanister, @mattmiklic: After looking at a few of these a bit, I realized something about a few of the "status indicators" in that some of them are quite redundant and unnecessary. Specifically the Since those particular statuses are basically filters, it seems a bit redundant to also list them on the post card when the entire feed is that status. What you think of trimming down the status indicators to only apply on posts which could exist in a feed surrounded by other post types? This would apply to the following types of statuses: Few examples: Trashed |
These are still in flux in Calypso, so not changing them for now. See Automattic/wp-calypso#2338
I suppose it could get annoying if you had already filtered, BUT if you forgot you're viewing a filter you might miss that a post is trashed or scheduled (without looking at the other context clues). I can go either way on this—since it doesn't take up much space I'd probably leave the status indicators as they were, but don't have too much skin in the game. One other language nitpick I noticed—should the 'publish' button be 'Publish Now' for scheduled posts? Is that easy enough to conditionalize? |
Posts: status noticon replacement
On post cards displayed in
/posts/*
, changed the status icons from noticons to gridicon components. Updated the size to the standard18px
as well as switching a few specific status to more appropriate icon types.Testing
/posts
or any subsequent subpage that contains posts like scheduled, trashed, etc.18px
size.aside
bookmark-outline
calendar
trash
/cc @mattmiklic, @rickybanister