Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: Headstart: Update dependencies in the domains step. #3041

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

kwight
Copy link
Contributor

@kwight kwight commented Feb 3, 2016

This fixes a fatal error introduced by 752fa72.

To test:

  • Switch to this branch, then load the Headstart flow at calypso.localhost:3000/start/headstart.
  • Complete signup, making sure you don't see this error in the console: Uncaught Error: This step (domains-with-theme) provides an unspecified dependency [themeItem]. Make sure to specify it in /signup/config/steps.js, using the providesDependencies property.

…omains-with-theme` step.

This fixes a fatal error introduced by 752fa72.
@kwight kwight added [Type] Bug [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Feb 3, 2016
@kwight
Copy link
Contributor Author

kwight commented Feb 3, 2016

@michaeldcain for review

@michaeldcain
Copy link
Member

LGTM

kwight added a commit that referenced this pull request Feb 3, 2016
Signup: Headstart: Update dependencies in the domains step.
@kwight kwight merged commit 6d07424 into master Feb 3, 2016
@kwight kwight deleted the fix/headstart-domains-deps branch February 3, 2016 17:12
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants