Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: replace wpcom-private by wpcom-unpublished #305

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Framework: replace wpcom-private by wpcom-unpublished #305

merged 1 commit into from
Nov 20, 2015

Conversation

retrofox
Copy link
Contributor

Replace wpcom-private by wpcom-unpublished module.
wpcom-unpublished is a public repository located here: https://github.com/Automattic/wpcom-unpublished

@retrofox retrofox added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2015
@rralian
Copy link
Contributor

rralian commented Nov 20, 2015

This is tested and working for me. But I see something getting logged out in the console that probably shouldn't be there. I'm guessing from that particular version of wpcom-unublished?

inadvertant log

@rralian rralian added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2015
@retrofox
Copy link
Contributor Author

right @rralian. I've removed fs from wpcom-undocumented module because it isn't used. Automattic/wpcom-unpublished@18f0fd9.

@retrofox retrofox added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Nov 20, 2015
@blowery
Copy link
Contributor

blowery commented Nov 20, 2015

👍 :shipit:

@blowery blowery added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2015
retrofox added a commit that referenced this pull request Nov 20, 2015
@retrofox
Merge pull request #305 from Automattic/update/wpcom-unpublished
d0af5b6 
Framework: replace `wpcom-private` by `wpcom-unpublished`
@retrofox retrofox merged commit d0af5b6 into master Nov 20, 2015
@retrofox retrofox deleted the update/wpcom-unpublished branch November 20, 2015 21:37
@aduth aduth mentioned this pull request Nov 20, 2015
Merged
@retrofox retrofox restored the update/wpcom-unpublished branch November 21, 2015 12:42
@retrofox retrofox deleted the update/wpcom-unpublished branch November 21, 2015 12:42
@retrofox retrofox mentioned this pull request Nov 21, 2015
Merged
This was referenced Mar 17, 2020
Open
Open
@anarh anarh mentioned this pull request Mar 7, 2021
Open
@mdno mdno mentioned this pull request Mar 8, 2021
Open
@awaisab172 awaisab172 mentioned this pull request Mar 8, 2021
Open
@mayuba mayuba mentioned this pull request Mar 8, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Mar 8, 2021
Open
This was referenced Sep 15, 2021
Open
Open
This was referenced Sep 15, 2021
Open
Open
Open
@mayuba mayuba mentioned this pull request May 13, 2022
Open
@awaisab172 awaisab172 mentioned this pull request May 13, 2022
Open
@mdno mdno mentioned this pull request May 14, 2022
Open
@anarh anarh mentioned this pull request May 14, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Apr 30, 2023
Open
@anarh anarh mentioned this pull request Nov 28, 2023
Open
@mdno mdno mentioned this pull request Nov 28, 2023
Open
@mayuba mayuba mentioned this pull request Nov 28, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Nov 28, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@anarh anarh mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 30, 2023
Open
@mayuba mayuba mentioned this pull request May 13, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
@mdno mdno mentioned this pull request May 14, 2024
Open
@anarh anarh mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 23, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@retrofox @rralian @blowery @scruffian