Editor: Fix broken week display when week starts not on a Sunday

[akirk]

This fixes the calendar view for scheduled posts when the week doesn't start on a Sunday.

Old:

New:

Problem was a strict compare between string and number.

[aduth]

@akirk : Can you provide more detail about the original bug, as I'm having a hard time reproducing the issue. Does this only occur for specific browsers, locales, or sites? Only after a specific set of reproducible steps?

[aduth]

I can confirm that this only occurs on non-English locales (in my case, broken in French language). Testing fix now...

[akirk]

@aduth it happens on locales that have the week starting on days other than Sunday (for example French or German).

[aduth]

Confirmed that fix works, and that it makes sense that the translated value is returned as a string, but that it should in fact be cast to a Number* as you've done here. 👍

* Typo on ReactDayPicker docs? I expect it should be Number, not boolean.

[akirk]

Thanks!

Typo on ReactDayPicker docs? I expect it should be Number, not boolean.

Must be. This is the code within ReactDayPicker:

if (week.length > 0 && day.getDay() === firstDayOfWeek) {

[akirk]

Created a pull request in the react-day-picker repo: gpbl/react-day-picker#128

[aduth]

Created a pull request in the react-day-picker repo: gpbl/react-day-picker#128

OSS "Good Citizen Award" to you 👏 🏆 !