Remove the utils.regExpToString polyfill
#3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was needed for node 0.x, which we no longer support. This is basically reverting commit f472d91e5b3f3764acbb4d8471d7f1073644d323 from the old repo (`calypso-pre-oss`).
ockham
added
Framework
[Status] Needs Review
|
LGTM, assuming our production servers are running node > 4. |
sirbrillig
added
[Status] Ready to Merge
and removed
[Status] Needs Review
They are, as mandated by our |
ockham
added a commit
that referenced
this pull request
Feb 15, 2016
…regexptostring Remove the `utils.regExpToString` polyfill
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was needed for node 0.x, which we no longer support.
This is basically reverting commit f472d91e5b3f3764acbb4d8471d7f1073644d323 from
the old repo (
calypso-pre-oss).To test -- verify that the app still works (specifically, code-splitting/bundling for various routes).
CC @sirbrillig for review 🍵