People: Ensures form header strings are translated properly

[ebinnion]

Addresses part of #138

Previously, the form header title and description were incorrect for a role. The title did not take into account the user of a or an and the explanation was the same for every role.

This PR changes that.

Currently, it is quite verbose, so ping @deBhal for advice on trimming it down a bit.

To test:

• Checkout update/invite-translations branch
• Invite a test user to join a WordPress.com site by going to Users > Invite New in wp-admin
• In the invitation email, make note of the invitation key
• Go to /accept-invite/$site/$invite_key when you are both logged in and out
• Do the strings change between logged in and logged out?
• Now, go back to the invite users UI in wp-admin
• Invite the same user, but with a different role this time
• Refresh the tab that has Calypso loaded
• Do the strings represent the new role?

cc @lezama for an early review

[deBhal]

Thanks for the ping!

I think this is the good sort of verbose with separate complete sentences for the different roles. Nice one :)

You could streamline some of the calls a bit by moving the siteName up into the siteLink, like <a href={ this.getSiteDomain() } className="invite-header__site-link"> {this.getSiteName()} </a>;. That would let you use replace {{siteLink}}%(siteName)s{{/siteLink}} with {{siteLink/}} and drop the args out of those calls. I think you'd save a few lines, and make it a bit easier for both developers and translators to read.

[lezama]

this could be a const

[ebinnion]

cc @rickybanister for a wording review.

I based the wording off of the Summary of Roles in the .org codex.

[roccotripaldi]

Code-wise this looks great. I agree with @deBhal. The verbose strings make this very easy to understand. Tested, and works like a charm. LGTM.

[roccotripaldi]

Will we deal with the header text in an other PR?

[ebinnion]

Yessir. I plan on addressing the strings in InviteHeader in a separate PR.

[lezama]

LGTM

[rickybanister]

🚢