FSE: Fix editor frame styles after Gutenberg update. #37694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Pri] BLOCKER
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Copons
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
This LGTM and works as expected.
I've also tested full-width blocks (such as Site Description) inside a Cover block in a Template Part, and they aren't truncated anymore.
I think this is also an improvement over the previous versions, in that it seems there are less magic numbers! 😄
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest Gutenberg updates, there have been some changes to the editor styles (#). Essentially, this means that Gutenberg dislikes our frame/margin around the border of the editor much more than it did previously. I have tried to work around that as much as I can in this PR. It's not perfect, but I think it's a big improvement. Mobile styles aren't quite perfect, but they aren't that great in Gutenberg either.
Changes proposed in this Pull Request
Testing instructions
If you have any tips for how to fix some of the mobile styling, please let me know 😬
Fixes #37686