Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make client/ directory (Calypso app) a Lerna package #38190

Merged
merged 20 commits into from
Jan 16, 2020
Merged

Make client/ directory (Calypso app) a Lerna package #38190

merged 20 commits into from
Jan 16, 2020

Commits on Jan 16, 2020

  1. Move the validate-config-keys script (used in pre-commit hook) to bin/

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    be438ad View commit details
    Browse the repository at this point in the history

  2. Move webpack utility script for extensions aliases to client/webpack/ 

    That's also a great future location for all custom webpack-related modules. Better than
the currently used `server/bundler`.
    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    a036784 View commit details
    Browse the repository at this point in the history

  3. Remove lodash dependency from webpack configs

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6553390 View commit details
    Browse the repository at this point in the history

  4. Server analytics: improve imports from client dir

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    87a80e4 View commit details
    Browse the repository at this point in the history

  5. Move dev dependencies to top-level devDependencies

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b0a41c1 View commit details
    Browse the repository at this point in the history

  6. calypso-build: call npx with no-install, make enzyme a peer dependency

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    5b20b1c View commit details
    Browse the repository at this point in the history

  7. FSE: call wp-scripts with npx so that the bin location doesn't matter

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6bb0ef2 View commit details
    Browse the repository at this point in the history

  8. Dockerfile: disable the separate npm ci layer

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b44be89 View commit details
    Browse the repository at this point in the history

  9. FSE: don't npm ci before FSE build. There's only one global npm ci

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6f24de0 View commit details
    Browse the repository at this point in the history

  10. Remove separate apps/ lockfiles. There is only one global one

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    01710c2 View commit details
    Browse the repository at this point in the history

  11. Simplify imports from client/directory (use the short form)

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    f2d2e2f View commit details
    Browse the repository at this point in the history

  12. Move server/ to client/server/, update paths

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    8565cd9 View commit details
    Browse the repository at this point in the history

  13. Add client/ package to lerna config

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b899dbd View commit details
    Browse the repository at this point in the history

  14. Create client/package.json, move non-dev dependencies there

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b881c78 View commit details
    Browse the repository at this point in the history

  15. Fixup paths for ICFY stats

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    e2446f7 View commit details
    Browse the repository at this point in the history

  16. Fixup path in devdocs/selectors

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    cb47348 View commit details
    Browse the repository at this point in the history

  17. Devdocs: fixup import and externalizing of the search-index module 

    The request string and the externals declaration must exactly match. That makes
sure that `search-index.js` is not bundled into server bundle, but continues to be
read with `require( 'server/bundler/search-index')`.

Also removes legacy externals like `hot-reloader` or `bundler/assets` (the assets file
is read with `fs.readFile`, not with Node require)
    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    f52ea3d View commit details
    Browse the repository at this point in the history

  18. ESLint: fixup the configuration of the import/no-extraneous-modules 

    Don't specify a `packageDir` and make it look at the closest `package.json` by default.

Also, add `lodash` as a top-level dev dependency, as some build-only files (e.g., `.eslintrc`)
use it.
    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    25f72bf View commit details
    Browse the repository at this point in the history

  19. Update the (unified) lockfile

    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b195f48 View commit details
    Browse the repository at this point in the history

  20. Update the npm-package-json-lint configuration and runner 

    Allow `devDependencies` only in the root `package.json` and not anywhere else.
    @jsnajdr
    jsnajdr committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    9e9de37 View commit details
    Browse the repository at this point in the history