Data Stores: Disable automatic type inclusion #38688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
sirreal
added
[Status] Needs Review
Automatically including type definitions can be problematic. Only include imported types. See tsconfig types documentation: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types
sirreal
force-pushed
the
fix/no-auto-include-types-data-stores
branch
from
1581b1e
to
7e6499f
Compare
|
I had to apply the fix to all the tsconfigs in use as well as one additional change. This should be working well now. |
sirreal
commented
Jan 8, 2020
| @@ -1,4 +1,4 @@ | |||
| require( '@babel/polyfill' ); | |||
| import '@babel/polyfill'; | |||
There was a problem hiding this comment.
@nbloomf This seem OK to you?
Comment on lines
+5
to
+6
| "target": "ES5", | ||
| "lib": [ "DOM", "ES2015", "ScriptHost" ], |
There was a problem hiding this comment.
@nbloomf This seem OK to you?
My understanding is that target ES5 changes compiled output, while lib allows all ES2015 features, e.g. Promise, Set.
sirreal
added
[Status] Needs Review
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically including type definitions can be problematic. Only
include imported types.
See tsconfig types documentation:
https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types
Orinially reported by @jsnajdr
Testing instructions
npm run distclean && npm run update-depswill error on master (like above) but will correctly build on this branch.npx lerna run prepare --scope='@automattic/data-stores'is the specific command that would fail