ESLint: Cleanup obsolete server dir from .eslintignore

[tyxla]

Changes proposed in this Pull Request

• ESLint: Cleanup .eslintignore from obsolete server dirs

Testing instructions

• Shouldn't be necessary, as this removes no longer existing entries from the .eslintignore file.

[matticbot]

Test live: https://calypso.live/?branch=cleanup/eslintignore-server-dir

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~30996 bytes added 📈 [gzipped])

name      parsed_size    gzip_size
manifest    +172263 B     +30996 B

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~1756766 bytes added 📈 [gzipped])

name                   parsed_size    gzip_size
entry-gutenboarding     +2605188 B    +680249 B
entry-main              +1486589 B    +377137 B
entry-jetpack-cloud     +1424050 B    +361530 B
entry-login              +891510 B    +237638 B
entry-domains-landing    +376705 B    +100212 B

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6517409 bytes added 📈 [gzipped])

name                      parsed_size    gzip_size
checkout                   +1847248 B    +451393 B
woocommerce                +1543484 B    +380561 B
gutenberg-editor           +1350203 B    +349975 B
post-editor                +1324956 B    +341188 B
purchases                   +971613 B    +231293 B
settings-writing            +952053 B    +282912 B
stats                       +910168 B    +225818 B
domains                     +852693 B    +198973 B
preview                     +769560 B    +196309 B
jetpack-connect             +638435 B    +169618 B
marketing                   +621418 B    +153817 B
settings                    +609915 B    +159793 B
plugins                     +570331 B    +146259 B
comments                    +549080 B    +127920 B
activity                    +541458 B    +136693 B
reader                      +509167 B    +132051 B
people                      +460468 B    +116427 B
help                        +458367 B    +114253 B
plans                       +437042 B    +115346 B
media                       +391167 B    +106064 B
site-blocks                 +379187 B     +98371 B
themes                      +367833 B     +97912 B
home                        +343334 B     +91020 B
privacy                     +333505 B     +85102 B
security                    +332081 B     +91068 B
google-my-business          +314900 B     +86916 B
posts                       +314688 B     +82959 B
checklist                   +311919 B     +84227 B
pages                       +308931 B     +87490 B
concierge                   +308047 B     +75111 B
account                     +298215 B     +79987 B
email                       +295429 B     +78705 B
posts-custom                +291673 B     +77149 B
zoninator                   +286790 B     +80438 B
theme                       +278755 B     +75911 B
account-close               +277056 B     +74007 B
earn                        +272018 B     +70234 B
hosting                     +264742 B     +71832 B
notification-settings       +263055 B     +68966 B
settings-security           +258138 B     +70630 B
signup                      +257288 B     +54756 B
accept-invite               +256283 B     +68194 B
happychat                   +256010 B     +69453 B
settings-discussion         +251070 B     +67076 B
me                          +234971 B     +60680 B
customize                   +194981 B     +55391 B
export                      +184011 B     +50534 B
wp-super-cache              +167077 B     +47372 B
settings-performance        +161594 B     +46705 B
feature-upsell              +157730 B     +39525 B
migrate                     +148345 B     +40573 B
import                      +117039 B     +32347 B
sensei                      +106980 B     +30893 B
hello-dolly                 +101529 B     +28646 B
sites                       +100917 B     +28896 B
devdocs                      +67044 B     +18204 B
auth                         +17684 B      +5216 B
mailing-lists                +15259 B      +4608 B
domain-connect-authorize     +12745 B      +3642 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2188171 bytes added 📈 [gzipped])

name                                                         parsed_size    gzip_size
async-load-design-blocks                                      +2114495 B    +493494 B
async-load-design                                             +1147687 B    +259357 B
async-load-design-playground                                  +1068931 B    +238779 B
async-load-components-web-preview-component                    +361257 B     +93330 B
async-load-my-sites-site-settings-seo-settings-form            +280188 B     +74655 B
async-load-post-editor-media-modal                             +267926 B     +71827 B
async-load-blocks-inline-help-popover                          +242760 B     +59127 B
async-load-blocks-calendar-popover                             +239856 B     +46634 B
async-load-signup-steps-domains                                +218490 B     +52670 B
async-load-signup-steps-plans                                  +152050 B     +40257 B
async-load-signup-steps-clone-point                            +150669 B     +34936 B
async-load-my-sites-checklist-wpcom-checklist-component-jsx    +131347 B     +31698 B
async-load-emoji-text                                          +128902 B     +22496 B
async-load-apps-notifications-index-jsx                        +117398 B     +34526 B
async-load-signup-steps-user                                   +113493 B     +29920 B
async-load-reader-following-manage                             +110351 B     +29671 B
async-load-signup-steps-plans-atomic-store                      +97204 B     +25571 B
async-load-layout-guided-tours-component                        +94130 B     +20305 B
async-load-lib-preferences-helper                               +78198 B     +17914 B
async-load-blocks-support-article-dialog-dialog                 +76723 B     +21782 B
async-load-reader-search-stream                                 +65247 B     +18539 B
async-load-blocks-inline-help                                   +63134 B     +14882 B
async-load-lib-happychat-connection                             +61513 B     +17530 B
async-load-reader-sidebar                                       +55551 B     +14238 B
async-load-signup-steps-theme-selection                         +54069 B     +13688 B
async-load-my-sites-current-site-domain-warnings                +53385 B     +13232 B
async-load-signup-steps-about                                   +47982 B     +12175 B
async-load-my-sites-current-site-notice                         +44981 B     +10801 B
async-load-signup-steps-clone-credentials                       +43454 B     +11390 B
async-load-extensions-woocommerce-app-store-stats               +42847 B     +12150 B
async-load-extensions-woocommerce-app-store-stats-referrers     +42134 B     +11683 B
async-load-blocks-product-purchase-features-list                +41556 B      +9682 B
async-load-blocks-reader-full-post                              +40793 B     +11040 B
async-load-my-sites-current-site-stale-cart-items-notice        +40597 B     +11478 B
async-load-signup-steps-rewind-form-creds                       +38060 B     +10217 B
async-load-layout-guided-tours                                  +36261 B     +10017 B
async-load-components-happychat                                 +34606 B     +11064 B
async-load-signup-steps-site-topic                              +30299 B      +8529 B
async-load-signup-steps-import-url-onboarding                   +30275 B      +8826 B
async-load-signup-steps-site-style                              +29565 B      +9833 B
async-load-quick-language-switcher                              +28769 B      +8363 B
async-load-signup-steps-clone-ready                             +27540 B      +7624 B
async-load-post-editor-editor-sharing-accordion                 +25610 B      +6657 B
async-load-reader-site-stream                                   +24540 B      +6808 B
async-load-reader-feed-stream                                   +24444 B      +6747 B
async-load-signup-steps-passwordless                            +24316 B      +5980 B
async-load-signup-steps-rewind-migrate                          +24314 B      +6796 B
async-load-signup-steps-site                                    +24270 B      +6195 B
async-load-components-jetpack-header-inmotion                   +24215 B      +7229 B
async-load-my-sites-guided-transfer                             +22908 B      +5585 B
async-load-signup-steps-creds-confirm                           +22753 B      +6322 B
async-load-signup-steps-creds-permission                        +22627 B      +6339 B
async-load-layout-nps-survey-notice                             +22020 B      +5696 B
async-load-signup-steps-import-preview                          +20776 B      +6264 B
async-load-signup-steps-import-url                              +20011 B      +5671 B
async-load-blocks-jitm-templates-sidebar-banner                 +19958 B      +6113 B
async-load-signup-steps-site-or-domain                          +19254 B      +5468 B
async-load-components-jetpack-header-dreamhost                  +18500 B      +5587 B
async-load-blocks-jitm-templates-default                        +18322 B      +5784 B
async-load-layout-community-translator-launcher                 +18255 B      +5895 B
async-load-post-editor-editor-author                            +18085 B      +5209 B
async-load-signup-steps-clone-destination                       +17849 B      +4904 B
async-load-components-jetpack-header-pressable                  +17373 B      +5313 B
async-load-signup-steps-survey                                  +16562 B      +4394 B
async-load-components-jetpack-header-liquidweb                  +16478 B      +5788 B
async-load-reader-tag-stream-main                               +15755 B      +4762 B
async-load-extensions-woocommerce-app-store-stats-listview      +15662 B      +4488 B
async-load-signup-steps-clone-start                             +14074 B      +4093 B
async-load-signup-steps-clone-cloning                           +13595 B      +3970 B
async-load-signup-steps-rebrand-cities-welcome                  +12995 B      +3602 B
async-load-post-editor-editor-location                          +12872 B      +3880 B
async-load-signup-steps-site-type                               +11668 B      +3209 B
async-load-components-jetpack-header-bluehost                   +11588 B      +3361 B
async-load-signup-steps-reader-landing                          +11447 B      +3135 B
async-load-signup-steps-site-title                              +11115 B      +3071 B
async-load-reader-list-stream                                   +10550 B      +3050 B
async-load-signup-steps-clone-jetpack                           +10377 B      +2810 B
async-load-components-jetpack-header-eurodns                     +9892 B      +2476 B
async-load-lib-abtest-test-helper                                +8981 B      +3073 B
async-load-post-editor-editor-seo-accordion                      +8860 B      +2884 B
async-load-signup-steps-site-picker                              +8771 B      +2570 B
async-load-signup-steps-rewind-were-backing                      +8675 B      +2572 B
async-load-signup-steps-creds-complete                           +8630 B      +2585 B
async-load-blocks-app-banner                                     +8220 B      +2909 B
async-load-components-community-translator                       +8119 B      +2565 B
async-load-signup-steps-test-step                                +7942 B      +2317 B
async-load-layout-masterbar-drafts-popover                       +7342 B      +2502 B
async-load-components-signup-site-preview-component              +7204 B      +2259 B
async-load-blocks-product-plan-overlap-notices                   +6355 B      +2026 B
async-load-components-jetpack-header-woocommerce                 +5609 B      +1444 B
async-load-docs-selectors                                        +5589 B      +1766 B
async-load-design-typography                                     +5508 B      +1686 B
async-load-post-editor-editor-post-formats-accordion             +5189 B      +1740 B
async-load-blocks-inline-help-dialog                             +4972 B      +1963 B
async-load-post-editor-editor-discussion                         +4932 B      +1584 B
async-load-blocks-jitm                                           +4645 B      +1709 B
async-load-reader-conversations-stream                           +4447 B      +1634 B
async-load-lib-network-connection                                +4116 B      +1532 B
async-load-blocks-login-social-connect-prompt                    +3917 B      +1350 B
async-load-featured-image                                        +2872 B      +1026 B
async-load-components-webpack-build-monitor                      +2552 B      +1130 B
async-load-blocks-legal-updates-banner                           +2485 B      +1063 B
async-load-blocks-jitm-templates-notice                           +642 B       +391 B
async-load-components-jetpack-header-milesweb                     +628 B       +408 B
async-load-signup-steps-launch-site                               +536 B       +332 B
async-load-lib-rubberband-scroll-disable                          +487 B       +303 B
async-load-reader-team-main                                       +369 B       +267 B

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Moment.js Locales (~112657 bytes added 📈 [gzipped])

name                    parsed_size    gzip_size
moment-locale-en-au        +13823 B      +4898 B
moment-locale-ru            +4547 B      +1606 B
moment-locale-mr            +3437 B      +1275 B
moment-locale-bo            +3250 B      +1074 B
moment-locale-uk            +3242 B      +1435 B
moment-locale-ta            +3026 B      +1165 B
moment-locale-be            +2949 B      +1290 B
moment-locale-cs            +2882 B      +1170 B
moment-locale-ka            +2756 B       +995 B
moment-locale-ku            +2755 B      +1150 B
moment-locale-ar            +2663 B      +1186 B
moment-locale-ne            +2577 B      +1108 B
moment-locale-sw            +2518 B      +1091 B
moment-locale-ar-ly         +2506 B      +1111 B
moment-locale-he            +2505 B      +1089 B
moment-locale-el            +2484 B      +1220 B
moment-locale-bn            +2473 B      +1051 B
moment-locale-sl            +2462 B       +993 B
moment-locale-pa-in         +2461 B      +1022 B
moment-locale-ml            +2405 B       +959 B
moment-locale-hi            +2371 B      +1077 B
moment-locale-ur            +2366 B      +1020 B
moment-locale-km            +2322 B      +1010 B
moment-locale-me            +2320 B      +1102 B
moment-locale-tet           +2287 B       +959 B
moment-locale-es-us         +2209 B       +945 B
moment-locale-es-do         +2209 B       +946 B
moment-locale-es            +2192 B       +940 B
moment-locale-ms            +2185 B       +970 B
moment-locale-sq            +2150 B       +933 B
moment-locale-tlh           +2143 B       +891 B
moment-locale-nl            +2140 B       +938 B
moment-locale-it-ch         +2137 B       +966 B
moment-locale-hy-am         +2125 B       +940 B
moment-locale-tr            +2107 B       +860 B
moment-locale-lo            +2091 B       +976 B
moment-locale-pt-br         +2067 B       +995 B
moment-locale-sk            +2060 B       +863 B
moment-locale-th            +2053 B       +981 B
moment-locale-mk            +2045 B       +957 B
moment-locale-lt            +2044 B       +812 B
moment-locale-fa            +2038 B       +940 B
moment-locale-sr-cyrl       +2027 B       +952 B
moment-locale-hu            +2018 B       +932 B
moment-locale-pl            +2002 B       +940 B
moment-locale-nl-be         +1993 B       +937 B
moment-locale-fi            +1982 B       +894 B
moment-locale-bs            +1975 B       +877 B
moment-locale-gom-latn      +1967 B       +962 B
moment-locale-hr            +1940 B       +879 B
moment-locale-ar-sa         +1932 B       +921 B
moment-locale-is            +1925 B       +897 B
moment-locale-lv            +1895 B       +849 B
moment-locale-ca            +1823 B       +857 B
moment-locale-tzm           +1821 B       +653 B
moment-locale-lb            +1812 B       +942 B
moment-locale-ky            +1773 B       +892 B
moment-locale-kn            +1762 B       +875 B
moment-locale-zh-tw         +1759 B       +922 B
moment-locale-az            +1758 B       +914 B
moment-locale-zh-hk         +1752 B       +908 B
moment-locale-mn            +1750 B       +910 B
moment-locale-bg            +1730 B       +915 B
moment-locale-cv            +1693 B       +813 B
moment-locale-ug-cn         +1635 B       +867 B
moment-locale-dv            +1574 B       +818 B
moment-locale-br            +1548 B       +837 B
moment-locale-zh-cn         +1533 B       +852 B
moment-locale-ja            +1533 B       +771 B
moment-locale-vi            +1532 B       +771 B
moment-locale-ss            +1519 B       +805 B
moment-locale-gu            +1519 B       +738 B
moment-locale-et            +1498 B       +768 B
moment-locale-tzl           +1487 B       +799 B
moment-locale-ko            +1483 B       +733 B
moment-locale-mi            +1478 B       +749 B
moment-locale-de-at         +1471 B       +760 B
moment-locale-de-ch         +1462 B       +744 B
moment-locale-de            +1460 B       +753 B
moment-locale-ar-dz         +1451 B       +686 B
moment-locale-ar-tn         +1435 B       +680 B
moment-locale-ar-ma         +1432 B       +682 B
moment-locale-ar-kw         +1432 B       +681 B
moment-locale-uz            +1431 B       +710 B
moment-locale-cy            +1419 B       +761 B
moment-locale-kk            +1415 B       +738 B
moment-locale-ga            +1411 B       +769 B
moment-locale-yo            +1402 B       +705 B
moment-locale-fr            +1388 B       +727 B
moment-locale-gd            +1377 B       +755 B
moment-locale-eu            +1377 B       +692 B
moment-locale-fr-ch         +1373 B       +724 B
moment-locale-ms-my         +1372 B       +722 B
moment-locale-my            +1363 B       +719 B
moment-locale-uz-latn       +1357 B       +731 B
moment-locale-se            +1356 B       +755 B
moment-locale-fr-ca         +1354 B       +713 B
moment-locale-id            +1350 B       +718 B
moment-locale-gl            +1348 B       +735 B
moment-locale-eo            +1339 B       +734 B
moment-locale-af            +1332 B       +728 B
moment-locale-si            +1327 B       +708 B
moment-locale-sd            +1316 B       +702 B
moment-locale-jv            +1312 B       +721 B
moment-locale-pt            +1307 B       +703 B
moment-locale-it            +1303 B       +718 B
moment-locale-sr            +1292 B       +703 B
moment-locale-sv            +1282 B       +699 B
moment-locale-tg            +1263 B       +689 B
moment-locale-fy            +1256 B       +686 B
moment-locale-en-nz         +1256 B       +687 B
moment-locale-en-SG         +1252 B       +687 B
moment-locale-en-gb         +1252 B       +686 B
moment-locale-en-ie         +1251 B       +686 B
moment-locale-bm            +1246 B       +635 B
moment-locale-en-ca         +1240 B       +675 B
moment-locale-ro            +1225 B       +713 B
moment-locale-nb            +1225 B       +645 B
moment-locale-tl-ph         +1218 B       +657 B
moment-locale-en-il         +1217 B       +667 B
moment-locale-fo            +1205 B       +660 B
moment-locale-tzm-latn      +1189 B       +566 B
moment-locale-nn            +1186 B       +641 B
moment-locale-mt            +1175 B       +679 B
moment-locale-da            +1165 B       +633 B
moment-locale-te            +1161 B       +632 B
moment-locale-x-pseudo      +1157 B       +599 B

Locale data for moment.js. Unless you are upgrading the moment.js library, changes in these chunks are suspicious.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[jsnajdr]

It's a good idea to wait for some time before removing ignores like this. If you switch back and forth between PRs, some of them based on the old master, some on the new one, you might end up with files in /server that should be ignored, but aren't. The next step is to accidentally commit them 🙂

It's been a month since #38190 was merged. Is it enough? Not sure, but probably yes.

[tyxla]

@jsnajdr yes, the "accidentally committing them" is exactly why I'm touching .eslintignore, but leaving .gitignore as it is for now 😉

[jsnajdr]

yes, the "accidentally committing them" is exactly why I'm touching .eslintignore, but leaving .gitignore as it is for now

That's a good point! Let's 🚢 this and thank you for the cleanup!