SiteSettings: Add timezone section to general settings. #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
added
[Type] Enhancement
[Feature] Site Settings
retrofox
force-pushed
the
update/site-settings-timezone
branch
4 times, most recently
from
0b01813
to
6fe8b39
Compare
retrofox
changed the title
retrofox
force-pushed
the
update/site-settings-timezone
branch
from
6fe8b39
to
266ec01
Compare
retrofox
added
[Status] Needs Review
| if ( this.state.isOpen ) { | ||
| this.closeDropdown(); | ||
| } | ||
|
|
||
| if ( this.props.initialSelected !== nextProps.initialSelected ) { |
There was a problem hiding this comment.
What if the initialSelected prop changes after the user has made a selection? Should we retain the user's selection rather than overriding it? I'd be annoyed if I had to make my selection again. It looks like state.selected will be undefined until a selection is made, so could we add a check for typeof this.state.selected === 'undefined' before we setState?
retrofox
force-pushed
the
update/site-settings-timezone
branch
from
8a30208
to
f43efb7
Compare
| /> | ||
|
|
||
| <FormSettingExplanation> | ||
| { this.translate( 'Choose a city in the same timezone as you.' ) } |
There was a problem hiding this comment.
simpler: Choose a city in your timezone.
There was a problem hiding this comment.
👍 just FYI it was copied from wp-admin
retrofox
force-pushed
the
update/site-settings-timezone
branch
from
f43efb7
to
6690b4e
Compare
retrofox
force-pushed
the
update/site-settings-timezone
branch
from
6690b4e
to
8a1354e
Compare
|
Looks and works great for me! |
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
thanks @rralian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #3902
This PR adds a
timezonesdropdown to general settings which allows to the user customize the timezone of his site.Testing
Select your testing site and go to general settings page. The url should be something like http://calypso.localhost:3000/settings/general/
Select a timezone from the dropdown and save the site
The previous timezone should be there after a hard-refresh
Go to "Create a new post", open the post schedule component and pay attention to the timezone section. The current site timezone should be there with the difference in hours between you.