-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack connect: avoid showing a generic error message #5012
Jetpack connect: avoid showing a generic error message #5012
Conversation
…already authorized
Could we perhaps redirect the user to the next step instead? (or something like that?) |
@rickybanister we could do that... but pretty much that will mean that the user could not use the browser back button (also: confusing and infuriating as hell... as least for me as a user, I hate when I'm trying to go back in my browsing history and a site insists in forwarding me to the next step) |
LGTM! This made me realize that we need to handle cases where people manually go to |
@johnHackworth understood. Perhaps then we render a different set of components here or something. How would someone navigate to here in the first place? Would they have to type in that url? What about rendering a drake message saying you're already connected? |
@rickybanister this is the url where users are redirected to from their wp-admin ... I don't think we could render a different set of components since when we |
@rickybanister I'm going to merge this one, to avoid the error message, and we can add the drake screen in another PR |
If we are have just authorized a jetpack site, and we reload the page (or just go to the next screen and the go back to the authorization screen), right now we are going to see a "unknown error" message.
This is because we are trying to authorize the site again, and the API is returning an "already authorized" message, which is not controlled so it defaults to the default generic error message.
This PR changes this, so we can show an "already authorized" message:
How to test
@roccotripaldi @rickybanister