Notices: Make links white instead of blue #5064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellychoffman
added
Framework
[Status] Needs Review
|
The language change notification during signup suffers from the same problem. Default state: Hover state: |
|
Fixing this with a slightly different selector placement in #5076. |
|
@kellychoffman let me know if this is alright to you now in master. |
|
👍 All good. |
scruffian
removed
the
[Status] Needs Review
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
(domain blocked out)
To test: Add a domain to a site and view the notice that appears.
cc: @umurkontaci @MichaelArestad