Purchases: Disable cancel for pending_transfer domains #8859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domains that are pending transfer cannot be canelled
aidvu
force-pushed
the
update/no-cancel-purchases-if-pending-transfer
branch
from
8c49fab
to
d611d99
Compare
aidvu
added
[Type] Bug
[Status] Needs Review
umurkontaci
previously requested changes
Oct 20, 2016
| @@ -127,6 +131,10 @@ function isPaidWithPaypal( purchase ) { | |||
| return 'paypal' === purchase.payment.type; | |||
| } | |||
|
|
|||
| function isPendingTransfer( purchase ) { | |||
| return true === purchase.pendingTransfer; | |||
There was a problem hiding this comment.
No need for an equality check here.
| @@ -60,5 +61,9 @@ describe( 'index', () => { | |||
| it( 'should be cancelable when the purchase can have auto-renew disabled', () => { | |||
| expect( isCancelable( PLAN_PURCHASE ) ).to.be.true; | |||
| } ); | |||
|
|
|||
| it( 'should be cancelable when the purchase can have auto-renew disabled', () => { | |||
There was a problem hiding this comment.
CP mistake :) The test name needs a change
|
@umurkontaci Updated. :) |
|
LGTM! 🚢 |
klimeryk
added
[Status] Ready to Merge
and removed
[Status] Needs Review
bisko
pushed a commit
that referenced
this pull request
Nov 16, 2016
Disable cancel in `/purchases` for domains that are pending transfer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users were able to
canceldomains that were pending transfer through/purchases, although thecancelwould always fail.Hide the
canceloption if the domain ispending transfer.Requires D3106-code.