Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calypso #733

Merged
merged 6 commits into from
Jan 3, 2020
Merged

Update Calypso #733

merged 6 commits into from
Jan 3, 2020

Conversation

nsakaimbo
Copy link
Contributor

@nsakaimbo nsakaimbo commented Jan 2, 2020

Description:

This PR updates Calypso to latest master.

Motivation and Context:

Since the last update of Calypso in wp-desktop, Calypso migrated from node v10 to v12. This introduced a number of breaking changes (both at build- and runtime) which have been addressed in this and related PRs.

  • Fix build error: Ensure that correct spellchecker prebuilds are fetched at build time ([deps] Use Own Prebuilt Spellchecker #724)
  • Fix build error: Fix bug in Calypso's max_old_space_size logic, allowing heap/RAM requirements to be correctly overriden (wp-calypso ea170c6c and wp-desktop 7402e41f5)
  • Fix runtime error: Transpile updated dependency chalk in wp-calypso (issue 38527) (not specifically related to Node 12, but also recently introduced by Calypso)
  • Fix runtime error: Polyfill for newly-introduced usage of Array.flat by wp-calypso (917c5ed)

How Has This Been Tested:

Confirmed the application builds and runs successfully both locally and on CI.

Copy link

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nsakaimbo nsakaimbo merged commit 797d651 into develop Jan 3, 2020
@nsakaimbo nsakaimbo deleted the update-calypso branch January 3, 2020 15:07
@jsnajdr
Copy link
Member

jsnajdr commented Jan 6, 2020

@nsakaimbo Did this PR fix the crashes that reported that flat function is undefined? The addition of CoreJS 3 polyfills is suspiciously similar to a possible fix for that issue 🙂

@belcherj
Copy link

belcherj commented Jan 7, 2020

@jsnajdr Yes, should have fixed flat issue.

Fix runtime error: Polyfill for newly-introduced usage of Array.flat by wp-calypso (917c5ed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants