Fix ICommand bindings in style setters
#16122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling a binding to e.g. `Button.Command` in a style `Setter`, we were not converting `XamlIlClrMethodPathElementNode` to `XamlIlClrMethodAsCommandPathElementNode` as we were only testing whether the property that the binding was being assigned to is an `ICommand`. If we detect that we're assigning the binding to a `Setter.Value` then we need to look in the `Setter.Property` to see check whether the property is an `ICommand` too. Fixes #16113
grokys
changed the title
ICommand bindings in styles
grokys
changed the title
ICommand bindings in stylesICommand bindings in style setters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jun 26, 2024
grokys
added a commit
that referenced
this pull request
Jun 28, 2024
* Add failing test for #16113. * Convert delegate to ICommand in style setter. When compiling a binding to e.g. `Button.Command` in a style `Setter`, we were not converting `XamlIlClrMethodPathElementNode` to `XamlIlClrMethodAsCommandPathElementNode` as we were only testing whether the property that the binding was being assigned to is an `ICommand`. If we detect that we're assigning the binding to a `Setter.Value` then we need to look in the `Setter.Property` to see check whether the property is an `ICommand` too. Fixes #16113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #16113, when compiling a binding to e.g.
Button.Commandin a styleSetter, we were not convertingXamlIlClrMethodPathElementNodetoXamlIlClrMethodAsCommandPathElementNodeas we were only testing whether the property that the binding was being assigned to is anICommand: in this caseSetter.Valueis anobjectso the conversion wasn't happening.If we detect that we're assigning the binding to a
Setter.Valuethen we need to look in theSetter.Propertyto see check whether the property is anICommandtoo.Fixed issues
Fixes #16113