Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to purge rooms to room list #44

Merged
merged 5 commits into from
Oct 7, 2020

Conversation

dklimpel
Copy link
Contributor

Add button (BulkDeleteButton) to delete rooms with no local users:

Fix: #17
Replace: #32

Add button (BulkDeleteButton) to delete rooms with no local users:
- purge rooms `POST /_synapse/admin/v1/purge_room`
(https://github.com/matrix-org/synapse/blob/master/docs/admin_api/purge_room.md)
@dklimpel
Copy link
Contributor Author

The button is also replaceble by matrix-org/synapse#7613 or a second button. Purge vs. Shutdown

@awesome-michael
Copy link
Member

I'd rather have the Button use the delete room endpoint. Purging empty rooms is a maintenance task I see in a planned maintenance section in Synapse Admin.

@dklimpel
Copy link
Contributor Author

The feature ist not landed today: matrix-org/synapse#7613
To shutdown a room do not delete events from database. It will block the room only.

@dklimpel dklimpel marked this pull request as draft July 21, 2020 17:26
@dklimpel dklimpel marked this pull request as ready for review July 21, 2020 19:16
@awesome-michael awesome-michael merged commit 26b8cea into Awesome-Technologies:master Oct 7, 2020
@dklimpel dklimpel deleted the purge_room branch December 16, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rooms deletion not work
2 participants