all changes #1009
all changes #1009
Conversation
| @@ -16,7 +16,6 @@ | |||
| AntiCycler, Cycler, CyclerCCD, CyclerCCCD, CyclerCCCCCD, | |||
| CyclerDC, CyclerDDC, CyclerCCCDCD) | |||
| from .darwin import Darwin | |||
| from .dbs import DBS | |||
There was a problem hiding this comment.
You seem to have deleted lines of code that are not part of your PR.
| @@ -64,7 +63,7 @@ | |||
| from .qlearner import ( | |||
| RiskyQLearner, ArrogantQLearner, HesitantQLearner, CautiousQLearner) | |||
| from .rand import Random | |||
| from .resurrection import Resurrection, DoubleResurrection | |||
There was a problem hiding this comment.
More lines have been deleted.
| from .verybad import VeryBad | ||
| from .worse_and_worse import (WorseAndWorse, KnowledgeableWorseAndWorse, | ||
| WorseAndWorse2, WorseAndWorse3) | ||
|
|
||
| from .axelrod_first import SteinAndRapoport |
There was a problem hiding this comment.
This can just be put in the earlier line where we have multiple strategies with from .axelrod_first ...
| # Note: Meta* strategies are handled in .__init__.py | ||
|
|
||
| all_strategies = [ | ||
| Adaptive, | ||
| AdaptiveTitForTat, | ||
| Aggravater, | ||
| Alexei, |
There was a problem hiding this comment.
More things being deleted.
| times15_in_list = (round_number // 15) * 15 | ||
| # lets suppose we are in 28th round | ||
| # So we still play according to chi-squared test in the 15th round | ||
| all_c = 0 # Each time we consider the whole history |
There was a problem hiding this comment.
You don't need this, you can just use opponent.cooperations and opponent.defections, so your test would just be chisquare([opponent.cooperations, opponent.defections]), you only need to do that every fifteen moves though so something like:
if len(self.history) % 15 == 0:
chisquare(...)There was a problem hiding this comment.
Let's get the PR and the commits aligned first before we worry about this though.
#379
Stein and Rapoport strategy to be implemented into axelrod_first
Please tell me if its everything ok with these 3 files and if so what i have to do in order to fix the test problem ;)
Thanks a lot