Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix citations link on readme #1225

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Fix citations link on readme #1225

merged 2 commits into from
Dec 17, 2018

Conversation

marcharper
Copy link
Member

@marcharper marcharper commented Dec 14, 2018

Edit: also merge Vince's modifications for appveyor, which were merged from #1226 into this PR.

@drvinceknight
Copy link
Member

I believe the failure is something to do with the windows platform (64 vs 32 bit?), I've made some attempts on #1226 (a PR to your branch) but without success.

@drvinceknight
Copy link
Member

I believe the failure is something to do with the windows platform (64 vs 32 bit?), I've made some attempts on #1226 (a PR to your branch) but without success.

Scrap that, looks like #1226 fixes things, I tried one last thing which was to not use conda envs anymore and rely on the wheels (our use of conda was due to things not working nicely which is probably fixed now). I haven't seen the full test suite pass (need to take the pup out for a walk) but the tests are all running and no more 32/64 error 👍

#1226 also has the advantage of really clearing up appveyor.yml.

I suggest you merge #1226 (squash the history?) in to this branch which should (famous last words) fix all test failures. 👍

@drvinceknight
Copy link
Member

Once tests failures are fixed this is obviously good to go from my pov 👍

* Attempt to fix error on appveyor.

I'm essentially attempting to apply information from
https://stackoverflow.com/questions/30143999/python-dll-load-failed-1-is-not-a-valid-win32-application
and
https://stackoverflow.com/questions/33709391/using-multiple-python-engines-32bit-64bit-and-2-7-3-5

* Attempt to force 64 bit.

* Specify 64 bit properly.

* Attempt to not use conda env at all.

* Specify no build

* Use win env python.
@drvinceknight
Copy link
Member

Merging (it's essentially a bug fix :)).

@drvinceknight drvinceknight merged commit 4f6e8bf into master Dec 17, 2018
@marcharper marcharper deleted the marcharper-patch-2 branch December 28, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants