Fix ResultSet __eq__ to handle nans #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For future reference, we try to not merge our own PRs just to be sure. 2 positive reviews and one of those usually merges. |
drvinceknight
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Looks good to me 👍
(I believe travis is happy: https://travis-ci.org/github/Axelrod-Python/Axelrod/builds/669025852?utm_medium=notification&utm_source=github_status)
|
LGTM, can you rebase on the most recent master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of #1301 which was broken and rolled back.
The error is that I was using matrix[i, j] but this is a list of lists and not a numpy-style matrix, so I changed to matrix[i][j].
I will wait for tests and approvals this time. :D