Noise in Spatial Tournament #677
Conversation
| @@ -44,7 +44,7 @@ def test_len(self): | |||
| with self.assertRaises(NotImplementedError): | |||
| len(tt) | |||
|
|
|||
| def test_build_match_params(self): | |||
| def _params(self): | |||
There was a problem hiding this comment.
you seem to have lost test_build_match_. I expect this test was not running (always make sure your test fails before it passes :)).
test match generator as an argument. Wrote an extra test for the noise.
|
@Nikoleta-v3 Please see the PR that I opened on your branch. We need to add a test that actually runs a spatial tournament to catch the bug I just fixed... |
I wondered how the doctest caught something our unit tests didn't... Any idea why this test does not catch whatever the bug was: https://github.com/Axelrod-Python/Axelrod/blob/master/axelrod/tests/unit/test_tournament.py#L621 (Haven't really spoken to @Nikoleta-v3 today, I know she's busy with some writing.) |
|
I'm not sure really but it was a tuple unpacking issue for match chunks so I would think that one of the other tests would have invoked it. |
|
Strange. Definitely worth including the example from the doc test as a unit test to make sure it doesn't happen again (and that we're not counting on the doctests to find bugs) :) |
|
I have opened https://github.com/Nikoleta-v3/Axelrod/pull/2 with the tests that I feel are necessary. Note that I opened that to your master branch as I didn't go through your fixes: we can chat about this when we catch up today. |
|
Have spoken to @Nikoleta-v3 and she's asked that I just submit my fix to this as she's had a bunch of data back that needs analysing. I'm closing this and about to open another PR. |
|
@marcharper Thank you for the comments ! I read everything through 😄 |
Closes #673
The bug seems to have been my fault as I was not passing the argument noise to either
the
SpatialMatchesgenerator or theSpatialTournamentclass.It has been corrected and also I added a test for the noise in the
test_match_generatorarcooding to @drvinceknight work in theTestProbEndSpatialTournament.Locally all 1595 tests seems to be running fine. Let's see what Travis has to say.