Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long_run_time classifier #692

Merged
merged 1 commit into from
Aug 14, 2016
Merged

Add long_run_time classifier #692

merged 1 commit into from
Aug 14, 2016

Conversation

drvinceknight
Copy link
Member

Closes #690.

@marcharper
Copy link
Member

This is good. Maybe we should have a standard run time metric, like run time versus TFT over 100 runs or similar.

@drvinceknight
Copy link
Member Author

Maybe we should have a standard run time metric, like run time versus TFT over 100 runs or similar.

I quite liked the timing ranking you put together here https://github.com/Axelrod-Python/Axelrod-notebooks/blob/master/Axelrod-Strategy-Times.ipynb. Could we not just re run that if and when a strategy comes in that we think might have a long run time?

@marcharper
Copy link
Member

Sure, I'm just suggesting an official definition for newcomers. In the spreadsheet associated to that notebook I standardized the values by dividing by the run time of one of the deterministic strategies. So I'm suggesting that we say some like run time is considered long if it's > 10x TFT (or whatever), and link to the notebook for a timing function of some kind that compares e.g. 100 matches of TFT vs TFT and 100 of TFT vs new_strategy.

We can discuss outside the PR, I think it's fine as is.

@drvinceknight
Copy link
Member Author

Cool I see what you mean. Sounds good, perhaps a number of standard
deviations from the mean time of all strategies? Just a suggestion, I don't
have a strong opinion on what definition/guideline we go for.

On Fri, 12 Aug 2016, 15:07 Marc Harper, notifications@github.com wrote:

Sure, I'm just suggesting an official definition for newcomers. In the
spreadsheet associated to that notebook I standardized the values by
dividing by the run time of one of the deterministic strategies. So I'm
suggesting that we say some like run time is considered long if it's > 10x
TFT (or whatever), and link to the notebook for a timing function of some
kind that compares e.g. 100 matches of TFT vs TFT and 100 of TFT vs
new_strategy.

We can discuss outside the PR, I think it's fine as is.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#692 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCGWkPAlr8GseWnxyT70-aB1hAqU_5fks5qfH4TgaJpZM4Jim3T
.

@meatballs meatballs merged commit b9b4a6b into master Aug 14, 2016
@marcharper marcharper deleted the 690 branch August 20, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants