Meta Winner Ensemble #757
Merged
Meta Winner Ensemble #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballs
reviewed
Nov 4, 2016
| t.proposed_history.append(r) | ||
|
|
||
| if opponent.defections == 0: | ||
| # Don't poke the bear |
meatballs
approved these changes
Nov 4, 2016
drvinceknight
requested changes
Nov 4, 2016
There was a problem hiding this comment.
As well as my two small requests, I don't understand why this hasn't tripped this test (which should check that it's in long_run_time_strategies): https://github.com/Axelrod-Python/Axelrod/blob/master/axelrod/tests/unit/test_classification.py#L170
| @@ -165,6 +165,32 @@ def meta_strategy(self, results, opponent): | |||
|
|
|||
| return bestresult | |||
|
|
|||
| class MetaWinnerEnsemble(MetaWinner): | |||
| """A variant of MetaWinner that chooses one of the top scoring strategies at random against each opponent.""" | |||
There was a problem hiding this comment.
Could you add something like:
Names:
Meta Winner Ensemble: Original name by Marc Harper
|
|
||
| def test_strategy(self): | ||
| self.first_play_test(C) | ||
|
|
There was a problem hiding this comment.
Could you add a test (for a given random seed) just for a few plays please.
There was a problem hiding this comment.
I added two deterministic test cases.
|
|
drvinceknight
approved these changes
Nov 5, 2016
|
Thanks @marcharper :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New strategy: Meta Winner Ensemble
Rather than take the "best" strategy, this MetaWinner variant chooses randomly from some of the top strategies computed each round against each opponent. In the full tournament it comes in 7th and is now the current best meta strategy.
I spent a little time tuning the parameter of how many strategies to pick from but not a lot, so it's possible that there's room for improvement.