-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Strategies: Mem2, Pun1, Collective Strategy #795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor docstring requests from me.
|
||
FSMPlayer.__init__(self, transitions, initial_state=1, initial_action=C) | ||
|
||
|
||
class Pun1(FSMPlayer): | ||
"""FSM player described in [Ashlock2006].""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write this docstrings to match up with the convention (not all of them follow it yet, slow conversion :)). In particular for this it should have (appended to what is already there).
Names
- Pun1 [Aslhlock2006]_
history of play is accessible. | ||
|
||
Names | ||
----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No -----
, just:
Names:
- ...
Otherwise, CS will always defect.' | ||
|
||
Names: | ||
Collective Strategy [Li2009] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Collective Strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
All from the literature.