-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to tournament #935
Add type hints to tournament #935
Conversation
@areebahmed04 There are failures in the tests. Take a look here- https://travis-ci.org/Axelrod-Python/Axelrod/jobs/215282242#L500 |
Please let us know if you need help |
@souravsingh How can i check for errors before push? |
The error you are getting is in the unit tests. There is information on running the tests here: http://axelrod.readthedocs.io/en/latest/tutorials/contributing/index.html In this instance this line:
Is importing
You get the following error:
So you need to use |
Test was successful locally but getting this error on Travis.
|
It is a sporadic failure. It should be fixed by a restart @drvinceknight |
Yup, I've restarted that, I'm going to see if I can fix that particular error so that it stops happening. |
This should hopefully stop sporadic failures on travis (due to timeouts) - mentioned on #935
This should hopefully stop sporadic failures on travis (due to timeouts) - mentioned on #935
Thanks for this @areebahmed04, could you add |
axelrod/tournament.py
Outdated
name='axelrod', game=None, turns=200, repetitions=10, | ||
noise=0, with_morality=True): | ||
def __init__(self, players: List[Player], match_generator: MatchGenerator=RoundRobinMatches, | ||
name: str='axelrod', game: Game=None, turns: int=200, repetitions:int =10, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo: missing space in repetitions:int=10
@areebahmed04 I've marked this as ready to merge. We have a policy where at least 2 of the core team have to approve a PR before it's merged. One of the others will be along when they are able. |
@drvinceknight @souravsingh @meatballs Thanks for the help! This was my first PR. |
Fantastic! Welcome to the project and we will look forward to your next PR. |
This should hopefully stop sporadic failures on travis (due to timeouts) - mentioned on #935
Unsure about edges, chunk, results.
Error when adding type hints to setup_output() in line 60.
def setup_output(self, filename=None, in_memory=False):