Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the repr for the Human strategy. #959

Merged
merged 1 commit into from
Apr 2, 2017
Merged

Override the repr for the Human strategy. #959

merged 1 commit into from
Apr 2, 2017

Conversation

drvinceknight
Copy link
Member

Closes #958.

@marcharper
Copy link
Member

This is fine but perhaps there's a better place for c_symbol and d_symbol -- maybe in the Actions class. There are similar parameters for sparklines (in Match).

@drvinceknight
Copy link
Member Author

👍 I'm throwing the ready to merge label on this (and have done on #955) as a visual prompt to Owen but please throw it off if you had left it off on purpose because you wanted to look at it again.

P.S. Open to moving the symbol commands (although they feel natural to me here from a UI pov, and perhaps could interface to the Actions class on #816 when we get to that).

@marcharper
Copy link
Member

I'm fine with merging this.

@meatballs meatballs merged commit f2553d0 into master Apr 2, 2017
@meatballs meatballs deleted the 958 branch April 2, 2017 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants