Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External DNS v0.11 #262

Merged
merged 5 commits into from
May 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/ByoVnetCI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ env:
AZCLIVERSION: 2.30.0 #2.29.2 #2.26.0 #latest
RG: "Automation-Actions-AksDeployCI"
ParamFilePath: ".github/workflows_dep/AksDeploy-ByoVnet.parameters.json"
RESNAME: "Byo"
RESNAME: "Byov"
DEPNAME: "Dep${{ github.run_number }}"
KVACCESS: "IAM"

Expand Down Expand Up @@ -531,7 +531,7 @@ jobs:

Post-Deploy:
needs: [Deploy, ReusableWF]
uses: azure/aks-construction/.github/workflows/PostDeploy.yml@0.4.3
uses: ./.github/workflows/PostDeploy.yml
with:
RG: ${{ needs.ReusableWF.outputs.RG }}
AKSNAME: ${{needs.Deploy.outputs.AKSNAME}}
Expand Down Expand Up @@ -559,8 +559,10 @@ jobs:
SmokeTest_JavaApp-certmgr:
needs: [Deploy, ReusableWF, Post-Deploy]
#uses: azure/aks-construction/.github/workflows/AppDeploy_JavaApp.yml@0.4.2-preview
uses: azure-samples/java-aks-keyvault-tls/.github/workflows/deployapp.yml@0.9
uses: azure-samples/java-aks-keyvault-tls/.github/workflows/deployapp.yml@0.9.1
with:
#REPOREF: "0.9.1-preview"
#HELMAPPURI: "helm/openjdk-demo-3.6.0.tgz"
RG: ${{ needs.ReusableWF.outputs.RG }} #Automation-Actions-AksDeployCI #'${{ env.RG }}' There seems to be an issue passing Env variables in reusable workflows
AKSNAME: ${{needs.Deploy.outputs.AKSNAME}}
DNSDOMAIN: azdemo.co.uk
Expand All @@ -578,7 +580,7 @@ jobs:
SmokeTest_JavaApp-appgw:
needs: [Deploy, ReusableWF, Post-Deploy, SmokeTest_JavaApp-certmgr]
#uses: azure/aks-construction/.github/workflows/AppDeploy_JavaApp.yml@0.4.2-preview
uses: azure-samples/java-aks-keyvault-tls/.github/workflows/deployapp.yml@0.9
uses: azure-samples/java-aks-keyvault-tls/.github/workflows/deployapp.yml@0.9.1
with:
RG: ${{ needs.ReusableWF.outputs.RG }} #Automation-Actions-AksDeployCI #'${{ env.RG }}' There seems to be an issue passing Env variables in reusable workflows
AKSNAME: ${{needs.Deploy.outputs.AKSNAME}}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/PostDeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ on:
required: false
type: string
HELMEXTERNALDNSURI:
default: "postdeploy/helm/externaldns-0.2.0.tgz"
default: "postdeploy/helm/externaldns-0.3.0.tgz"
required: false
type: string
CERTMANAGER:
type: boolean
default: true
required: false
CERTMANAGERVERSION:
default: "v1.5.3"
default: "v1.8.0"
required: false
type: string
CERTMANAGEREMAIL:
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:

- name: Kubelogin
env:
kubeloginversion: 'v0.0.10'
kubeloginversion: 'v0.0.13'
run: |
wget https://github.com/Azure/kubelogin/releases/download/${{ env.kubeloginversion }}/kubelogin-linux-amd64.zip
unzip kubelogin-linux-amd64.zip
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows_dep/AksDeploy-ByoVnet.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
"resourceName": {
"value": "byo"
},
"kubernetesVersion": {
"value": "1.21.9"
},
"agentCount": {
"value": 1
},
Expand Down
Binary file added postdeploy/helm/externaldns-0.3.0.tgz
Binary file not shown.
4 changes: 2 additions & 2 deletions postdeploy/helm/externaldns/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: externaldns
description: A Helm chart for externaldns
type: application
version: 0.2.0 #chart version
appVersion: "1.16.0" #your app version (used as an image tag)
version: 0.3.0 #chart version
appVersion: "v0.11.0" #your app version (used as an image tag)
2 changes: 1 addition & 1 deletion postdeploy/helm/externaldns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ volumeAndSecretname: azure-config-file
image:
repository: k8s.gcr.io/external-dns/external-dns
pullPolicy: IfNotPresent #Always
tag: "v0.8.0" #image tag should be set in Chart.yaml - but where it's a strange tag, just override here
tag: "" #image tag should be set in Chart.yaml - but where it's a strange tag, just override here

service:
type: ClusterIP
Expand Down